Fix ARM_CC_FOR_TARGET handling
authorPedro Alves <pedro@palves.net>
Thu, 9 Jun 2022 14:32:52 +0000 (15:32 +0100)
committerPedro Alves <pedro@palves.net>
Thu, 9 Jun 2022 14:36:34 +0000 (15:36 +0100)
The previous patch that introduced the arm_cc_for_target procedure
moved the ARM_CC_FOR_TARGET global check to that procedure, but forgot
to tell tcl that ARM_CC_FOR_TARGET is a global.  As a result,
specifying ARM_CC_FOR_TARGET on the command line actually does
nothing.  This fixes it.

Change-Id: I4e33b7633fa665e2f7b8f8c9592a949d74a19153

gdb/testsuite/lib/gdb.exp

index 67e5838a7a760659ee37bb0418d92a25a8dd203d..37accd9947aa413845d67793dd453d5cc3d038c7 100644 (file)
@@ -8671,12 +8671,12 @@ proc get_set_option_choices {set_cmd} {
 # that the executable they produce can run.
 
 gdb_caching_proc arm_cc_for_target {
-    if {[info exists ARM_CC_FOR_TARGET]} {
+    if {[info exists ::ARM_CC_FOR_TARGET]} {
        # If the user specified the compiler explicitly, then don't
        # check whether the resulting binary runs outside GDB.  Assume
        # that it does, and if it turns out it doesn't, then the user
        # should get loud FAILs, instead of UNSUPPORTED.
-       return $ARM_CC_FOR_TARGET
+       return $::ARM_CC_FOR_TARGET
     }
 
     # Fallback to a few common compiler names.  Also confirm the