PR23781, _bfd_pe_bfd_copy_private_bfd_data_common memory leak

	PR 23781
	* peXXigen.c (_bfd_XX_bfd_copy_private_bfd_data_common): Free data
	before returning.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 5031fff93d1a299b5a1c309c84dcdb559cb46c67..ab665ed08ec385fa070a34d6d43b13afe8606109 100644 (file)
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,9 @@
+2018-10-16  Alan Modra  <amodra@gmail.com>
+
+       PR 23781
+       * peXXigen.c (_bfd_XX_bfd_copy_private_bfd_data_common): Free data
+       before returning.
+
 2018-10-16  Alan Modra  <amodra@gmail.com>
 
        PR 23534

diff --git a/bfd/peXXigen.c b/bfd/peXXigen.c
index 1645ef4b77cb682e2593c633b4feaad61306a04a..1271d4edbbe54d17361f2330399eb421ad5a31c3 100644 (file)
--- a/bfd/peXXigen.c
+++ b/bfd/peXXigen.c
@@ -2993,6 +2993,7 @@ _bfd_XX_bfd_copy_private_bfd_data_common (bfd * ibfd, bfd * obfd)
                   "exceeds space left in section (%" PRIx64 ")"),
                 obfd, ope->pe_opthdr.DataDirectory[PE_DEBUG_DATA].Size,
                 (uint64_t) (section->size - (addr - section->vma)));
+             free (data);
              return FALSE;
            }
          /* PR 23110.  */
@@ -3002,6 +3003,7 @@ _bfd_XX_bfd_copy_private_bfd_data_common (bfd * ibfd, bfd * obfd)
              _bfd_error_handler
                (_("%pB: Data Directory size (%#lx) is negative"),
                 obfd, ope->pe_opthdr.DataDirectory[PE_DEBUG_DATA].Size);
+             free (data);
              return FALSE;
            }
 
@@ -3030,8 +3032,10 @@ _bfd_XX_bfd_copy_private_bfd_data_common (bfd * ibfd, bfd * obfd)
          if (!bfd_set_section_contents (obfd, section, data, 0, section->size))
            {
              _bfd_error_handler (_("failed to update file offsets in debug directory"));
+             free (data);
              return FALSE;
            }
+         free (data);
        }
       else if (section)
        {