package/mesa3d: reorder select/depends
authorRomain Naour <romain.naour@gmail.com>
Mon, 4 Jan 2016 00:11:45 +0000 (01:11 +0100)
committerPeter Korsgaard <peter@korsgaard.com>
Mon, 4 Jan 2016 23:15:08 +0000 (00:15 +0100)
>From [1]:
"Even though the ordering has absolutely no consequences in Kconfig, it
is not logical (when reading). It is more logical and far easier to
understand when depends come first, followed by the selects."

Also, the Config.in exemple in the manual suggest to use this coding
style [2].

[1] http://lists.busybox.net/pipermail/buildroot/2015-October/142955.html
[2] http://buildroot.uclibc.org/downloads/manual/manual.html#writing-rules-config-in

Signed-off-by: Romain Naour <romain.naour@gmail.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
package/mesa3d/Config.in

index 6e16f9d64316d6163d479c1118577432dd295e4f..fd7e7f855ea872571cbdb03f5c1c020c36fbe26c 100644 (file)
@@ -1,5 +1,10 @@
 menuconfig BR2_PACKAGE_MESA3D
        bool "mesa3d"
+       depends on BR2_INSTALL_LIBSTDCPP
+       depends on !BR2_STATIC_LIBS
+       depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
+       # Triggers the _gp link issue in nios2
+       depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_NIOSII
        select BR2_PACKAGE_LIBDRM
        select BR2_PACKAGE_EXPAT
        select BR2_PACKAGE_XPROTO_DRI2PROTO if BR2_PACKAGE_XORG7
@@ -10,11 +15,6 @@ menuconfig BR2_PACKAGE_MESA3D
        select BR2_PACKAGE_XLIB_LIBXDAMAGE if BR2_PACKAGE_XORG7
        select BR2_PACKAGE_XLIB_LIBXFIXES if BR2_PACKAGE_XORG7
        select BR2_PACKAGE_LIBXCB if BR2_PACKAGE_XORG7
-       depends on BR2_INSTALL_LIBSTDCPP
-       depends on !BR2_STATIC_LIBS
-       depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
-       # Triggers the _gp link issue in nios2
-       depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_NIOSII
        help
          Mesa 3D, an open-source implementation of the OpenGL specification.