libstdc++: Fix default mode of new basic_stringstream constructor [PR 97719]
authorJonathan Wakely <jwakely@redhat.com>
Wed, 4 Nov 2020 21:44:05 +0000 (21:44 +0000)
committerJonathan Wakely <jwakely@redhat.com>
Wed, 4 Nov 2020 23:41:02 +0000 (23:41 +0000)
libstdc++-v3/ChangeLog:

PR libstdc++/97719
* include/std/sstream (basic_stringstream(string_type&&, openmode)):
Fix default argument.
* testsuite/27_io/basic_stringstream/cons/char/97719.cc: New test.

libstdc++-v3/include/std/sstream
libstdc++-v3/testsuite/27_io/basic_stringstream/cons/char/97719.cc [new file with mode: 0644]

index 33a00486606ccbd3b32516e7e5900a0e6f757498..8acf1eb259abc6c3e73c1f5b89f8056015ca6f37 100644 (file)
@@ -976,7 +976,7 @@ _GLIBCXX_BEGIN_NAMESPACE_CXX11
 
       explicit
       basic_stringstream(__string_type&& __str,
-                        ios_base::openmode __mode = ios_base::out
+                        ios_base::openmode __mode = ios_base::in
                                                     | ios_base::out)
       : __iostream_type(), _M_stringbuf(std::move(__str), __mode)
       { this->init(std::__addressof(_M_stringbuf)); }
diff --git a/libstdc++-v3/testsuite/27_io/basic_stringstream/cons/char/97719.cc b/libstdc++-v3/testsuite/27_io/basic_stringstream/cons/char/97719.cc
new file mode 100644 (file)
index 0000000..fa523a8
--- /dev/null
@@ -0,0 +1,40 @@
+// Copyright (C) 2020 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library.  This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3.  If not see
+// <http://www.gnu.org/licenses/>.
+
+// { dg-options "-std=gnu++2a" }
+// { dg-do run { target c++2a } }
+
+#include <sstream>
+#include <iterator>
+#include <testsuite_hooks.h>
+
+void
+test01()
+{
+  // PR libstdc++/97719
+  std::string str = "a";
+  std::stringstream s(std::move(str));
+  std::istreambuf_iterator<char> i(s);
+  VERIFY( i != std::istreambuf_iterator<char>() );
+  VERIFY( *i == 'a' );
+}
+
+int
+main()
+{
+  test01();
+}