Add a warning to the bfd library for when it encounters an ELF file with an invalid...

	PR 23657
	* elfcode.h (elf_swap_shdr_in): Generate a warning message if an
	ELF section has contents and size larger than the file size.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 70de004135811a80f2535c41533ddbe176fb191e..04c0c2ab5c8d8f9ab8d7c1da4007dc1e3e01c673 100644 (file)
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,9 @@
+2018-09-18  Nick Clifton  <nickc@redhat.com>
+
+       PR 23657
+       * elfcode.h (elf_swap_shdr_in): Generate a warning message if an
+       ELF section has contents and size larger than the file size.
+
 2018-09-14  Maciej W. Rozycki  <macro@mips.com>
 
        PR ld/21375

diff --git a/bfd/elfcode.h b/bfd/elfcode.h
index fb02e255fdec73887101d6541a4c0ea56c59fcdd..f224c8b79d2fb0516a90c1a8ad818d11a1a971a5 100644 (file)
--- a/bfd/elfcode.h
+++ b/bfd/elfcode.h
@@ -314,6 +314,14 @@ elf_swap_shdr_in (bfd *abfd,
     dst->sh_addr = H_GET_WORD (abfd, src->sh_addr);
   dst->sh_offset = H_GET_WORD (abfd, src->sh_offset);
   dst->sh_size = H_GET_WORD (abfd, src->sh_size);
+  /* PR 23657.  Check for invalid section size, in sections with contents.
+     Note - we do not set an error value here because the contents
+     of this particular section might not be needed by the consumer.  */
+  if (dst->sh_type != SHT_NOBITS
+      && dst->sh_size > bfd_get_file_size (abfd))
+    _bfd_error_handler
+      (_("warning: %pB has a corrupt section with a size (%" BFD_VMA_FMT "x) larger than the file size"),
+       abfd, dst->sh_size);
   dst->sh_link = H_GET_32 (abfd, src->sh_link);
   dst->sh_info = H_GET_32 (abfd, src->sh_info);
   dst->sh_addralign = H_GET_WORD (abfd, src->sh_addralign);