tree-vect-loop.c (vect_is_simple_reduction): Remove operand swapping.

2019-09-18  Richard Biener  <rguenther@suse.de>

	* tree-vect-loop.c (vect_is_simple_reduction): Remove operand
	swapping.
	(vectorize_fold_left_reduction): Remove assert.
	(vectorizable_reduction): Also expect COND_EXPR non-reduction
	operand in position 2.  Remove assert.

From-SVN: r275898

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 2b55a3f4dc7cad0f6007cc9388236fd97501b07e..13d5cb95988511b6fce66928b2684de867613f3a 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,11 @@
+2019-09-18  Richard Biener  <rguenther@suse.de>
+
+       * tree-vect-loop.c (vect_is_simple_reduction): Remove operand
+       swapping.
+       (vectorize_fold_left_reduction): Remove assert.
+       (vectorizable_reduction): Also expect COND_EXPR non-reduction
+       operand in position 2.  Remove assert.
+
 2019-09-18  Wilco Dijkstra  <wdijkstr@arm.com>
 
        * config/arm/arm.md (arm_mulsi3): Remove pattern.

diff --git a/gcc/tree-vect-loop.c b/gcc/tree-vect-loop.c
index daf3370a52bc3585f0d1f1deceefebaec36497aa..bcd96394841cb07c4c41ef177f6ca53404536105 100644 (file)
--- a/gcc/tree-vect-loop.c
+++ b/gcc/tree-vect-loop.c
@@ -3280,56 +3280,8 @@ vect_is_simple_reduction (loop_vec_info loop_info, stmt_vec_info phi_info,
          || !flow_bb_inside_loop_p (loop, gimple_bb (def2_info->stmt))
          || vect_valid_reduction_input_p (def2_info)))
     {
-      if (! nested_in_vect_loop && orig_code != MINUS_EXPR)
-       {
-         /* Check if we can swap operands (just for simplicity - so that
-            the rest of the code can assume that the reduction variable
-            is always the last (second) argument).  */
-         if (code == COND_EXPR)
-           {
-             /* Swap cond_expr by inverting the condition.  */
-             tree cond_expr = gimple_assign_rhs1 (def_stmt);
-             enum tree_code invert_code = ERROR_MARK;
-             enum tree_code cond_code = TREE_CODE (cond_expr);
-
-             if (TREE_CODE_CLASS (cond_code) == tcc_comparison)
-               {
-                 bool honor_nans = HONOR_NANS (TREE_OPERAND (cond_expr, 0));
-                 invert_code = invert_tree_comparison (cond_code, honor_nans);
-               }
-             if (invert_code != ERROR_MARK)
-               {
-                 TREE_SET_CODE (cond_expr, invert_code);
-                 swap_ssa_operands (def_stmt,
-                                    gimple_assign_rhs2_ptr (def_stmt),
-                                    gimple_assign_rhs3_ptr (def_stmt));
-               }
-             else
-               {
-                 if (dump_enabled_p ())
-                   report_vect_op (MSG_NOTE, def_stmt,
-                                   "detected reduction: cannot swap operands "
-                                   "for cond_expr");
-                 return NULL;
-               }
-           }
-         else
-           swap_ssa_operands (def_stmt, gimple_assign_rhs1_ptr (def_stmt),
-                              gimple_assign_rhs2_ptr (def_stmt));
-
-         if (dump_enabled_p ())
-           report_vect_op (MSG_NOTE, def_stmt,
-                           "detected reduction: need to swap operands: ");
-
-         if (CONSTANT_CLASS_P (gimple_assign_rhs1 (def_stmt)))
-           LOOP_VINFO_OPERANDS_SWAPPED (loop_info) = true;
-        }
-      else
-        {
-          if (dump_enabled_p ())
-            report_vect_op (MSG_NOTE, def_stmt, "detected reduction: ");
-        }
-
+      if (dump_enabled_p ())
+       report_vect_op (MSG_NOTE, def_stmt, "detected reduction: ");
       return def_stmt_info;
     }
 
@@ -5969,7 +5921,6 @@ vectorize_fold_left_reduction (stmt_vec_info stmt_info,
   gcc_assert (!nested_in_vect_loop_p (loop, stmt_info));
   gcc_assert (ncopies == 1);
   gcc_assert (TREE_CODE_LENGTH (code) == binary_op);
-  gcc_assert (reduc_index == (code == MINUS_EXPR ? 0 : 1));
   gcc_assert (STMT_VINFO_VEC_REDUCTION_TYPE (stmt_info)
              == FOLD_LEFT_REDUCTION);
 
@@ -6542,9 +6493,9 @@ vectorizable_reduction (stmt_vec_info stmt_info, gimple_stmt_iterator *gsi,
          reduc_index = i;
        }
 
-      if (i == 1 && code == COND_EXPR)
+      if (code == COND_EXPR)
        {
-         /* Record how value of COND_EXPR is defined.  */
+         /* Record how the non-reduction-def value of COND_EXPR is defined.  */
          if (dt == vect_constant_def)
            {
              cond_reduc_dt = dt;
@@ -6622,10 +6573,6 @@ vectorizable_reduction (stmt_vec_info stmt_info, gimple_stmt_iterator *gsi,
          return false;
        }
 
-      /* vect_is_simple_reduction ensured that operand 2 is the
-        loop-carried operand.  */
-      gcc_assert (reduc_index == 2);
-
       /* Loop peeling modifies initial value of reduction PHI, which
         makes the reduction stmt to be transformed different to the
         original stmt analyzed.  We need to record reduction code for