PR24876, readelf: heap-buffer-overflow in dump_ia64_unwind

	PR 24876
	* readelf.c (dump_ia64_unwind): Check that buffer is large
	enough for "stamp" before reading.

diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index 411f835ef892d5129dec758214209c9070b4a290..f60d5ffbb02ab04bc444f94c2c84b47a43d98608 100644 (file)
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,9 @@
+2019-08-07  Alan Modra  <amodra@gmail.com>
+
+       PR 24876
+       * readelf.c (dump_ia64_unwind): Check that buffer is large
+       enough for "stamp" before reading.
+
 2019-08-05  Nick Clifton  <nickc@redhat.com>
 
        PR 24874

diff --git a/binutils/readelf.c b/binutils/readelf.c
index e785fde43e7c0de796dd77e1e689826370a3e4c6..5e18734f10b9455e9bac3dd6b875fbd820730e39 100644 (file)
--- a/binutils/readelf.c
+++ b/binutils/readelf.c
@@ -7574,7 +7574,8 @@ dump_ia64_unwind (Filedata * filedata, struct ia64_unw_aux_info * aux)
        }
       offset -= aux->info_addr;
       /* PR 17531: file: 0997b4d1.  */
-      if (offset >= aux->info_size)
+      if (offset >= aux->info_size
+         || aux->info_size - offset < 8)
        {
          warn (_("Invalid offset %lx in table entry %ld\n"),
                (long) tp->info.offset, (long) (tp - aux->table));