.gitlab-ci.yml: simplify (and fix) check-DEVELOPERS

The check-DEVELOPERS test would always fail, because && will return
the exit code of the left-hand side if not 0, so it *always* returns
1.

But in fact, the test can be simplified quite a lot: we can run
getdeveloper directly, without arguments. That should just print
'No action specified', but it will also print any syntax errors it
encountered. So we can just 'grep -v' the expected output away; if
there is anything more, grep will return 0, but if there is nothing
more, it will return 1. So we just need to invert the result.

Incidentally, this also fixes the incorrect remaining reference to
support/scripts.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index cc048a0df66239e330521556771e7b5e5ecea939..6bd983750dd69b63771941a9d4a920e429b47097 100644 (file)
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -36,9 +36,7 @@ check-gitlab-ci.yml:
 
 check-DEVELOPERS:
     script:
-        - PYTHONPATH=$PWD/support/scripts
-                python -c 'from getdeveloperlib import parse_developers; parse_developers()' |
-                grep . && exit 1
+        - ! utils/get-developers | grep -v 'No action specified'
 
 .defconfig: &defconfig
     # Running the defconfigs for every push is too much, so limit to

diff --git a/.gitlab-ci.yml.in b/.gitlab-ci.yml.in
index 0b6e634a4b045e6d63d1cd9c7dfe09fc13ddcc54..0855bffb7919faa5fbe947d6e229504a4eb922a6 100644 (file)
--- a/.gitlab-ci.yml.in
+++ b/.gitlab-ci.yml.in
@@ -36,9 +36,7 @@ check-gitlab-ci.yml:
 
 check-DEVELOPERS:
     script:
-        - PYTHONPATH=$PWD/support/scripts
-                python -c 'from getdeveloperlib import parse_developers; parse_developers()' |
-                grep . && exit 1
+        - ! utils/get-developers | grep -v 'No action specified'
 
 .defconfig: &defconfig
     # Running the defconfigs for every push is too much, so limit to