intel/vec4: Don't try both sources as immediates for DPH
authorIan Romanick <ian.d.romanick@intel.com>
Mon, 15 Jul 2019 18:38:55 +0000 (11:38 -0700)
committerIan Romanick <ian.d.romanick@intel.com>
Thu, 17 Oct 2019 22:07:01 +0000 (15:07 -0700)
DPH isn't actually commutative, so this doesn't work.  If the immediate
in src0 would be a VF candidate, we could do better. *shrug*

No shader-db changes on any Intel platform.

Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com>
Fixes: b04beaf41d2 ("intel/vec4: Try both sources as candidates for being immediates")
src/intel/compiler/brw_vec4_nir.cpp

index c357ee2271b322312d55698d38e32b7e15a74958..7bc31755609bbbc16ae6e72c04329e25b53b1d65 100644 (file)
@@ -1951,7 +1951,7 @@ vec4_visitor::nir_emit_alu(nir_alu_instr *instr)
       break;
 
    case nir_op_fdph_replicated:
-      try_immediate_source(instr, op, true, devinfo);
+      try_immediate_source(instr, op, false, devinfo);
       inst = emit(BRW_OPCODE_DPH, dst, op[0], op[1]);
       inst->saturate = instr->dest.saturate;
       break;