freedreno/a5xx: use MRT0 to import linear zs
authorRob Clark <robdclark@gmail.com>
Mon, 12 Dec 2016 21:06:55 +0000 (16:06 -0500)
committerRob Clark <robdclark@gmail.com>
Sun, 18 Dec 2016 18:48:10 +0000 (13:48 -0500)
A bit of a hack, but we need to do this until we can do tiled zs in
sysmem (and associated tile/until blits for transfer_map).

Fixes xonotic and glmark2 "refract", when reorder wasn't enabled.
(reorder would paper over the issue by avoiding the extra round-
trip to system memory and back to gmem.

Signed-off-by: Rob Clark <robdclark@gmail.com>
src/gallium/drivers/freedreno/a5xx/fd5_gmem.c

index 21104c2f1dc61e77a5a9742d65772c6275c53fea..1920458461931c8e60ece3cba8d82fb276dcc990 100644 (file)
@@ -328,7 +328,7 @@ fd5_emit_tile_mem2gmem(struct fd_batch *batch, struct fd_tile *tile)
         */
 
        emit_mrt(ring, pfb->nr_cbufs, pfb->cbufs, NULL);
-       emit_zs(ring, pfb->zsbuf, NULL);
+//     emit_zs(ring, pfb->zsbuf, NULL);
 
        OUT_PKT4(ring, REG_A5XX_RB_CNTL, 1);
        OUT_RING(ring, A5XX_RB_CNTL_WIDTH(gmem->bin_w) |
@@ -351,10 +351,25 @@ fd5_emit_tile_mem2gmem(struct fd_batch *batch, struct fd_tile *tile)
                struct fd_resource *rsc = fd_resource(pfb->zsbuf->texture);
                // XXX BLIT_ZS vs BLIT_Z32 .. need some more cmdstream traces
                // with z32_x24s8..
-               if (!rsc->stencil || (batch->restore & FD_BUFFER_DEPTH))
-                       emit_mem2gmem_surf(batch, ctx->gmem.zsbuf_base[0], pfb->zsbuf, BLIT_ZS);
-               if (rsc->stencil && (batch->restore & FD_BUFFER_STENCIL))
-                       emit_mem2gmem_surf(batch, ctx->gmem.zsbuf_base[1], pfb->zsbuf, BLIT_ZS);
+
+               // XXX hack import via BLIT_MRT0 instead of BLIT_ZS, since I don't
+               // know otherwise how to go from linear in sysmem to tiled in gmem.
+               // possibly we want to flip this around gmem2mem and keep depth
+               // tiled in sysmem (and fixup sampler state to assume tiled).. this
+               // might be required for doing depth/stencil in bypass mode?
+               struct fd_resource_slice *slice = fd_resource_slice(rsc, 0);
+               enum a5xx_color_fmt format =
+                       fd5_pipe2color(fd_gmem_restore_format(pfb->zsbuf->format));
+
+               OUT_PKT4(ring, REG_A5XX_RB_MRT_BUF_INFO(0), 5);
+               OUT_RING(ring, A5XX_RB_MRT_BUF_INFO_COLOR_FORMAT(format) |
+                               A5XX_RB_MRT_BUF_INFO_COLOR_TILE_MODE(TILE5_LINEAR) |
+                               A5XX_RB_MRT_BUF_INFO_COLOR_SWAP(WZYX));
+               OUT_RING(ring, A5XX_RB_MRT_PITCH(slice->pitch * rsc->cpp));
+               OUT_RING(ring, A5XX_RB_MRT_ARRAY_PITCH(slice->size0));
+               OUT_RELOCW(ring, rsc->bo, 0, 0, 0);  /* BASE_LO/HI */
+
+               emit_mem2gmem_surf(batch, ctx->gmem.zsbuf_base[0], pfb->zsbuf, BLIT_MRT0);
        }
 }