Revert "gdb/python: Avoid use after free in py-tui.c"

This reverts commit 982a38f60b0ece9385556cff45567e06710478cb.

I missed that the title being assigned too was a std::string, and so
there is no leak.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 1d486c4b30051713a0dd0a115628a0f1842e74d3..5cd74e6c31b525cb43637848f443dd2132278ab2 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2020-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
+
+       Revert commit 982a38f60b0.
+       * python/py-tui.c (gdbpy_tui_set_title): Restore use of get.
+
 2020-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 
        * python/py-tui.c (gdbpy_tui_set_title): Use release, not get, to

diff --git a/gdb/python/py-tui.c b/gdb/python/py-tui.c
index f2c03395a0bc1632cc9a360c559985c6482f86f0..ca88f85eb9f9af4b38c2ed9276c9d7d9ab38dfc4 100644 (file)
--- a/gdb/python/py-tui.c
+++ b/gdb/python/py-tui.c
@@ -433,7 +433,7 @@ gdbpy_tui_set_title (PyObject *self, PyObject *newvalue, void *closure)
   if (value == nullptr)
     return -1;
 
-  win->window->title = value.release ();
+  win->window->title = value.get ();
   return 0;
 }