intel: Align untiled region height to 2 according to 965 docs.
authorEric Anholt <eric@anholt.net>
Sat, 8 Aug 2009 01:09:31 +0000 (18:09 -0700)
committerEric Anholt <eric@anholt.net>
Fri, 4 Sep 2009 21:12:36 +0000 (14:12 -0700)
This may or may not be required pre-965, but it doesn't seem unlikely, and
I'd rather be safe.
(cherry picked from commit b053474378633249be0e9f24010650ffb816229a)

src/mesa/drivers/dri/intel/intel_regions.c

index 0aa5b8c02c904a2b31c7ea51b49357db9a6dabd4..b8d2dec4cb76b9ca38ac111c4d2d855e26b0147e 100644 (file)
@@ -114,6 +114,13 @@ intel_region_alloc(struct intel_context *intel,
 {
    dri_bo *buffer;
 
+   /* If we're untiled, we have to align to 2 rows high because the
+    * data port accesses 2x2 blocks even if the bottom row isn't to be
+    * rendered, so failure to align means we could walk off the end of the
+    * GTT and fault.
+    */
+   height = ALIGN(height, 2);
+
    if (expect_accelerated_upload) {
       buffer = drm_intel_bo_alloc_for_render(intel->bufmgr, "region",
                                             pitch * cpp * height, 64);