convert to_get_trace_state_variable_value

2014-02-19  Tom Tromey  <tromey@redhat.com>

	* target-delegates.c: Rebuild.
	* target.c (update_current_target): Don't inherit or default
	to_get_trace_state_variable_value.
	* target.h (struct target_ops)
	<to_get_trace_state_variable_value>: Use TARGET_DEFAULT_RETURN.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 82e4973b4284ea453aefa96933749e7281705728..44b1a9611a37aa6be094bc75f48c4ca409b61d1a 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,11 @@
+2014-02-19  Tom Tromey  <tromey@redhat.com>
+
+       * target-delegates.c: Rebuild.
+       * target.c (update_current_target): Don't inherit or default
+       to_get_trace_state_variable_value.
+       * target.h (struct target_ops)
+       <to_get_trace_state_variable_value>: Use TARGET_DEFAULT_RETURN.
+
 2014-02-19  Tom Tromey  <tromey@redhat.com>
 
        * target-delegates.c: Rebuild.

diff --git a/gdb/target-delegates.c b/gdb/target-delegates.c
index 2fd51e289742e5fe17e808437359065c404196e2..4c934e7a0ffc206d00f465bd5c182d57c1597530 100644 (file)
--- a/gdb/target-delegates.c
+++ b/gdb/target-delegates.c
@@ -793,6 +793,19 @@ tdefault_trace_find (struct target_ops *self, enum trace_find_type  arg1, int ar
   return -1;
 }
 
+static int
+delegate_get_trace_state_variable_value (struct target_ops *self, int arg1, LONGEST *arg2)
+{
+  self = self->beneath;
+  return self->to_get_trace_state_variable_value (self, arg1, arg2);
+}
+
+static int
+tdefault_get_trace_state_variable_value (struct target_ops *self, int arg1, LONGEST *arg2)
+{
+  return 0;
+}
+
 static int
 delegate_supports_btrace (struct target_ops *self)
 {
@@ -945,6 +958,8 @@ install_delegators (struct target_ops *ops)
     ops->to_trace_stop = delegate_trace_stop;
   if (ops->to_trace_find == NULL)
     ops->to_trace_find = delegate_trace_find;
+  if (ops->to_get_trace_state_variable_value == NULL)
+    ops->to_get_trace_state_variable_value = delegate_get_trace_state_variable_value;
   if (ops->to_supports_btrace == NULL)
     ops->to_supports_btrace = delegate_supports_btrace;
 }
@@ -1020,5 +1035,6 @@ install_dummy_methods (struct target_ops *ops)
   ops->to_get_tracepoint_status = tdefault_get_tracepoint_status;
   ops->to_trace_stop = tdefault_trace_stop;
   ops->to_trace_find = tdefault_trace_find;
+  ops->to_get_trace_state_variable_value = tdefault_get_trace_state_variable_value;
   ops->to_supports_btrace = tdefault_supports_btrace;
 }

diff --git a/gdb/target.c b/gdb/target.c
index 9ef0762f967443ea24ab1e15fc098bb2cd665fbe..f0309f13263f57a74f98779764c5be2d4b02b264 100644 (file)
--- a/gdb/target.c
+++ b/gdb/target.c
@@ -700,7 +700,7 @@ update_current_target (void)
       /* Do not inherit to_get_tracepoint_status.  */
       /* Do not inherit to_trace_stop.  */
       /* Do not inherit to_trace_find.  */
-      INHERIT (to_get_trace_state_variable_value, t);
+      /* Do not inherit to_get_trace_state_variable_value.  */
       INHERIT (to_save_trace_data, t);
       INHERIT (to_upload_tracepoints, t);
       INHERIT (to_upload_trace_state_variables, t);
@@ -752,9 +752,6 @@ update_current_target (void)
            (void (*) (struct target_ops *, ptid_t))
            target_ignore);
   current_target.to_read_description = NULL;
-  de_fault (to_get_trace_state_variable_value,
-           (int (*) (struct target_ops *, int, LONGEST *))
-           return_zero);
   de_fault (to_save_trace_data,
            (int (*) (struct target_ops *, const char *))
            tcomplain);

diff --git a/gdb/target.h b/gdb/target.h
index f85ec560d34aaa104f3c9b884d3aef79d74c5af5..4331b9117f6fde914437f994c7c4994195cf8cbb 100644 (file)
--- a/gdb/target.h
+++ b/gdb/target.h
@@ -866,7 +866,8 @@ struct target_ops
        1 if the value is known and writing the value itself into the
        location pointed to by VAL, else returning 0.  */
     int (*to_get_trace_state_variable_value) (struct target_ops *,
-                                             int tsv, LONGEST *val);
+                                             int tsv, LONGEST *val)
+      TARGET_DEFAULT_RETURN (0);
 
     int (*to_save_trace_data) (struct target_ops *, const char *filename);