gdb/

	Fix modification of cplus_struct_default.
	* dwarf2read.c (dwarf2_add_member_fn) <no DW_AT_vtable_elem_location>:
	Call ALLOCATE_CPLUS_STRUCT_TYPE.
	* gdbtypes.c (cplus_struct_default): New empty initializer, comment it.

gdb/testsuite/
	* gdb.cp/virtbase.cc (class RTTI_base, class RTTI_data)
	(main) <rtti_data>: New.
	* gdb.cp/virtbase.exp (print rtti_data): New.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 4341e7209d7e63933142cd51074757d80db63754..196f89962dfcab1c22ec75654e50e055c323c230 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2010-06-28  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+       Fix modification of cplus_struct_default.
+       * dwarf2read.c (dwarf2_add_member_fn) <no DW_AT_vtable_elem_location>:
+       Call ALLOCATE_CPLUS_STRUCT_TYPE.
+       * gdbtypes.c (cplus_struct_default): New empty initializer, comment it.
+
 2010-06-28  Joel Brobecker  <brobecker@adacore.com>
 
        * NEWS: Add entry announcing the python directory.

diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index 43e7120c80c1cf75368df8ae458f4837cfce8e25..6893e08ac7c6a2acee086199aa26b88458ddbacd 100644 (file)
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -4954,6 +4954,7 @@ dwarf2_add_member_fn (struct field_info *fip, struct die_info *die,
          complaint (&symfile_complaints,
                     _("Member function \"%s\" (offset %d) is virtual but the vtable offset is not specified"),
                     fieldname, die->offset);
+         ALLOCATE_CPLUS_STRUCT_TYPE (type);
          TYPE_CPLUS_DYNAMIC (type) = 1;
        }
     }

diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c
index b7fb11001efaade835ac57cb6c7556ac6c44eee6..5d1d4203e79b1941b28f51a74c918f2ae5a442d9 100644 (file)
--- a/gdb/gdbtypes.c
+++ b/gdb/gdbtypes.c
@@ -1733,7 +1733,8 @@ check_stub_method_group (struct type *type, int method_id)
     }
 }
 
-const struct cplus_struct_type cplus_struct_default;
+/* Ensure it is in .rodata (if available) by workarounding GCC PR 44690.  */
+const struct cplus_struct_type cplus_struct_default = { };
 
 void
 allocate_cplus_struct_type (struct type *type)

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index cb8545315b0bd85ee75f39af3ba766dbe6bc51ec..e187d045e9eec42bfec11747adc09137a8e0a4a0 100644 (file)
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,9 @@
+2010-06-28  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+       * gdb.cp/virtbase.cc (class RTTI_base, class RTTI_data)
+       (main) <rtti_data>: New.
+       * gdb.cp/virtbase.exp (print rtti_data): New.
+
 2010-06-28  Jan Kratochvil  <jan.kratochvil@redhat.com>
            Joel Brobecker  <brobecker@adacore.com>
 

diff --git a/gdb/testsuite/gdb.cp/virtbase.cc b/gdb/testsuite/gdb.cp/virtbase.cc
index fed5927db553bd99554bd2ac5fddc05f9bb29f36..1e6874fd3b0d595bff3e52c556bb3964a1d0b783 100644 (file)
--- a/gdb/testsuite/gdb.cp/virtbase.cc
+++ b/gdb/testsuite/gdb.cp/virtbase.cc
@@ -74,8 +74,19 @@ public:
   virtual void b() {}
 };
 
+class RTTI_base
+{
+public:
+  virtual ~RTTI_base() {}
+};
 
-
+class RTTI_data
+{
+public:
+  RTTI_base base;
+  int data;
+  RTTI_data() : data(1) {}
+};
 
 int main() {
   ph::Derived tst;
@@ -84,6 +95,7 @@ int main() {
 
   E *e = new E;
   RHB *b = new RHC();
+  RTTI_data rtti_data;
 
   return 0;                    // breakpoint 3
 }

diff --git a/gdb/testsuite/gdb.cp/virtbase.exp b/gdb/testsuite/gdb.cp/virtbase.exp
index 1f845a79f8446000f9bbbc385586421b0ead4c1b..b9bde0810630ea8629524b160fff434f51b72ac0 100644 (file)
--- a/gdb/testsuite/gdb.cp/virtbase.exp
+++ b/gdb/testsuite/gdb.cp/virtbase.exp
@@ -60,3 +60,8 @@ gdb_test "print *(D *) e" " = {<C> = {v = 11}, _vptr.D = $hex}"
 # https://bugzilla.redhat.com/show_bug.cgi?id=560741
 gdb_test_no_output "set print object on"
 gdb_test "print/x b->mA" " = 0xaaaaaaaa"
+
+# A regression test reported to Red Hat bugzilla, see:
+# https://bugzilla.redhat.com/show_bug.cgi?id=606660
+# `set print object on' is expected.
+gdb_test "print rtti_data" " = .*, data = 1\}"