csky: tidy csky_chars_to_number

	* csky-dis.c (csky_chars_to_number): Remove abort and unnecessary
	mask.

diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog
index 2a44855e4f7cc7ee74d854ac16d889cbe231e84a..9e0d57b7c9c6ac183596edc371108f637f45a1a8 100644 (file)
--- a/opcodes/ChangeLog
+++ b/opcodes/ChangeLog
@@ -1,3 +1,8 @@
+2019-12-12  Alan Modra  <amodra@gmail.com>
+
+       * csky-dis.c (csky_chars_to_number): Remove abort and unnecessary
+       mask.
+
 2019-12-11  Alan Modra  <amodra@gmail.com>
 
        * arc-dis.c (BITS): Don't truncate high bits with shifts.

diff --git a/opcodes/csky-dis.c b/opcodes/csky-dis.c
index af830f3651999a36bd978ee4f3b52b7625133439..d7ffb13b5fdae4561419dfabb421f03f46824aae 100644 (file)
--- a/opcodes/csky-dis.c
+++ b/opcodes/csky-dis.c
@@ -134,17 +134,15 @@ csky_get_mask (struct csky_opcode_info const *pinfo)
 static unsigned int
 csky_chars_to_number (unsigned char * buf, int n)
 {
-  if (n <= 0)
-    abort ();
   int i;
   unsigned int val = 0;
 
   if (dis_info.info->endian == BFD_ENDIAN_BIG)
     for (i = 0; i < n; i++)
-      val = val << 8 | (buf[i] & 0xff);
+      val = val << 8 | buf[i];
   else
     for (i = n - 1; i >= 0; i--)
-      val = val << 8 | (buf[i] & 0xff);
+      val = val << 8 | buf[i];
   return val;
 }