freedreno/a6xx: Drop the WFI in the program update stateobj.
authorEric Anholt <eric@anholt.net>
Wed, 17 Jul 2019 19:56:12 +0000 (12:56 -0700)
committerEric Anholt <eric@anholt.net>
Wed, 17 Jul 2019 23:20:12 +0000 (16:20 -0700)
Rob Clark thinks this was likely a workaround for our const buffer
update bugs, and now that it's passing tests, we should be able to
drop it.

renderdoc-traces results:

traces/android/clashofclans.rdc:  +6.1% +/-   1.1%
traces/android/candycrush.rdc:    +5.2% +/-   1.6%

Reviewed-by: Rob Clark <robdclark@gmail.com>
src/gallium/drivers/freedreno/a6xx/fd6_program.c

index 76099177030b2b44aa2e88f7397f0cd8d3b9f211..7714f569f9685152bcf3a2254cdce2e3c0396b1b 100644 (file)
@@ -263,8 +263,6 @@ setup_stateobj(struct fd_ringbuffer *ring, struct fd6_program_state *state,
        uint8_t psize_loc = ~0;
        int i, j;
 
-       OUT_WFI5(ring);
-
        static const struct ir3_shader_variant dummy_fs = {0};
        const struct ir3_shader_variant *vs = binning_pass ? state->bs : state->vs;
        const struct ir3_shader_variant *fs = binning_pass ? &dummy_fs : state->fs;