iris: leave XXX about unnecessary binding table uploads
authorKenneth Graunke <kenneth@whitecape.org>
Fri, 19 Oct 2018 04:15:02 +0000 (21:15 -0700)
committerKenneth Graunke <kenneth@whitecape.org>
Thu, 21 Feb 2019 18:26:09 +0000 (10:26 -0800)
src/gallium/drivers/iris/iris_state.c

index 0a1127440f166965a5e1b886540a41e39b5e201b..f36838262e584b99e6322683c0193cc85b98c749 100644 (file)
@@ -4309,6 +4309,8 @@ iris_upload_compute_state(struct iris_context *ice,
                          .stride_B = 1,
                          .mocs = MOCS_WB);
 
+   // XXX: this will update the binding table on every dispatch, should
+   // XXX: check if the grid size actually changed (or indirect buf changed)
    if (dirty & IRIS_DIRTY_BINDINGS_CS || grid_size_res)
       iris_populate_binding_table(ice, batch, MESA_SHADER_COMPUTE, false,
                                   &grid_size_surf);