Don't copy a string in mi_cmd_disassemble

This string copy in mi_cmd_disassemble seems not to be needed, so
don't do it.

gdb/ChangeLog
2017-09-29  Tom Tromey  <tom@tromey.com>

	* mi/mi-cmd-disas.c (mi_cmd_disassemble): Don't copy "oarg".

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 2aaaabead73828f233d4b1e87b63314f40b6616d..004e0b0f0ff977074c4923d8777e1ff227866b1d 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2017-09-29  Tom Tromey  <tom@tromey.com>
+
+       * mi/mi-cmd-disas.c (mi_cmd_disassemble): Don't copy "oarg".
+
 2017-09-29  Tom Tromey  <tom@tromey.com>
 
        * varobj.h (varobj_gen_name): Return std::string.

diff --git a/gdb/mi/mi-cmd-disas.c b/gdb/mi/mi-cmd-disas.c
index d0f9b0b83ad2e6bbe9a87ced8e40c71d990257b9..b3d6245c2cca3bac70ccc614a10a1f9ab3897047 100644 (file)
--- a/gdb/mi/mi-cmd-disas.c
+++ b/gdb/mi/mi-cmd-disas.c
@@ -74,7 +74,6 @@ mi_cmd_disassemble (const char *command, char **argv, int argc)
   int how_many = -1;
   CORE_ADDR low = 0;
   CORE_ADDR high = 0;
-  struct cleanup *cleanups = make_cleanup (null_cleanup, NULL);
 
   /* Options processing stuff.  */
   int oind = 0;
@@ -104,9 +103,8 @@ mi_cmd_disassemble (const char *command, char **argv, int argc)
       switch ((enum opt) opt)
        {
        case FILE_OPT:
-         file_string = xstrdup (oarg);
+         file_string = oarg;
          file_seen = 1;
-         make_cleanup (xfree, file_string);
          break;
        case LINE_OPT:
          line_num = atoi (oarg);
@@ -190,6 +188,4 @@ mi_cmd_disassemble (const char *command, char **argv, int argc)
   gdb_disassembly (gdbarch, uiout,
                   disasm_flags,
                   how_many, low, high);
-
-  do_cleanups (cleanups);
 }