#include "iris_resource.h"
#include "iris_screen.h"
+/**
+ * Helper function for handling mirror image blits.
+ *
+ * If coord0 > coord1, swap them and return "true" (mirrored).
+ */
+static bool
+apply_mirror(float *coord0, float *coord1)
+{
+ if (*coord0 > *coord1) {
+ float tmp = *coord0;
+ *coord0 = *coord1;
+ *coord1 = tmp;
+ return true;
+ }
+ return false;
+}
+
+/**
+ * Compute the number of pixels to clip for each side of a rect
+ *
+ * \param x0 The rect's left coordinate
+ * \param y0 The rect's bottom coordinate
+ * \param x1 The rect's right coordinate
+ * \param y1 The rect's top coordinate
+ * \param min_x The clipping region's left coordinate
+ * \param min_y The clipping region's bottom coordinate
+ * \param max_x The clipping region's right coordinate
+ * \param max_y The clipping region's top coordinate
+ * \param clipped_x0 The number of pixels to clip from the left side
+ * \param clipped_y0 The number of pixels to clip from the bottom side
+ * \param clipped_x1 The number of pixels to clip from the right side
+ * \param clipped_y1 The number of pixels to clip from the top side
+ *
+ * \return false if we clip everything away, true otherwise
+ */
+static inline bool
+compute_pixels_clipped(float x0, float y0, float x1, float y1,
+ float min_x, float min_y, float max_x, float max_y,
+ float *clipped_x0, float *clipped_y0,
+ float *clipped_x1, float *clipped_y1)
+{
+ /* If we are going to clip everything away, stop. */
+ if (!(min_x <= max_x &&
+ min_y <= max_y &&
+ x0 <= max_x &&
+ y0 <= max_y &&
+ min_x <= x1 &&
+ min_y <= y1 &&
+ x0 <= x1 &&
+ y0 <= y1)) {
+ return false;
+ }
+
+ if (x0 < min_x)
+ *clipped_x0 = min_x - x0;
+ else
+ *clipped_x0 = 0;
+ if (max_x < x1)
+ *clipped_x1 = x1 - max_x;
+ else
+ *clipped_x1 = 0;
+
+ if (y0 < min_y)
+ *clipped_y0 = min_y - y0;
+ else
+ *clipped_y0 = 0;
+ if (max_y < y1)
+ *clipped_y1 = y1 - max_y;
+ else
+ *clipped_y1 = 0;
+
+ return true;
+}
+
+/**
+ * Clips a coordinate (left, right, top or bottom) for the src or dst rect
+ * (whichever requires the largest clip) and adjusts the coordinate
+ * for the other rect accordingly.
+ *
+ * \param mirror true if mirroring is required
+ * \param src the source rect coordinate (for example src_x0)
+ * \param dst0 the dst rect coordinate (for example dst_x0)
+ * \param dst1 the opposite dst rect coordinate (for example dst_x1)
+ * \param clipped_dst0 number of pixels to clip from the dst coordinate
+ * \param clipped_dst1 number of pixels to clip from the opposite dst coordinate
+ * \param scale the src vs dst scale involved for that coordinate
+ * \param is_left_or_bottom true if we are clipping the left or bottom sides
+ * of the rect.
+ */
+static void
+clip_coordinates(bool mirror,
+ float *src, float *dst0, float *dst1,
+ float clipped_dst0,
+ float clipped_dst1,
+ float scale,
+ bool is_left_or_bottom)
+{
+ /* When clipping we need to add or subtract pixels from the original
+ * coordinates depending on whether we are acting on the left/bottom
+ * or right/top sides of the rect respectively. We assume we have to
+ * add them in the code below, and multiply by -1 when we should
+ * subtract.
+ */
+ int mult = is_left_or_bottom ? 1 : -1;
+
+ if (!mirror) {
+ *dst0 += clipped_dst0 * mult;
+ *src += clipped_dst0 * scale * mult;
+ } else {
+ *dst1 -= clipped_dst1 * mult;
+ *src += clipped_dst1 * scale * mult;
+ }
+}
+
+/**
+ * Apply a scissor rectangle to blit coordinates.
+ *
+ * Returns true if the blit was entirely scissored away.
+ */
+static bool
+apply_blit_scissor(const struct pipe_scissor_state *scissor,
+ float *src_x0, float *src_y0,
+ float *src_x1, float *src_y1,
+ float *dst_x0, float *dst_y0,
+ float *dst_x1, float *dst_y1,
+ bool mirror_x, bool mirror_y)
+{
+ float clip_dst_x0, clip_dst_x1, clip_dst_y0, clip_dst_y1;
+
+ /* Compute number of pixels to scissor away. */
+ if (!compute_pixels_clipped(*dst_x0, *dst_y0, *dst_x1, *dst_y1,
+ scissor->minx, scissor->miny,
+ scissor->maxx, scissor->maxy,
+ &clip_dst_x0, &clip_dst_y0,
+ &clip_dst_x1, &clip_dst_y1))
+ return true;
+
+ // XXX: comments assume source clipping, which we don't do
+
+ /* When clipping any of the two rects we need to adjust the coordinates
+ * in the other rect considering the scaling factor involved. To obtain
+ * the best precision we want to make sure that we only clip once per
+ * side to avoid accumulating errors due to the scaling adjustment.
+ *
+ * For example, if src_x0 and dst_x0 need both to be clipped we want to
+ * avoid the situation where we clip src_x0 first, then adjust dst_x0
+ * accordingly but then we realize that the resulting dst_x0 still needs
+ * to be clipped, so we clip dst_x0 and adjust src_x0 again. Because we are
+ * applying scaling factors to adjust the coordinates in each clipping
+ * pass we lose some precision and that can affect the results of the
+ * blorp blit operation slightly. What we want to do here is detect the
+ * rect that we should clip first for each side so that when we adjust
+ * the other rect we ensure the resulting coordinate does not need to be
+ * clipped again.
+ *
+ * The code below implements this by comparing the number of pixels that
+ * we need to clip for each side of both rects considering the scales
+ * involved. For example, clip_src_x0 represents the number of pixels
+ * to be clipped for the src rect's left side, so if clip_src_x0 = 5,
+ * clip_dst_x0 = 4 and scale_x = 2 it means that we are clipping more
+ * from the dst rect so we should clip dst_x0 only and adjust src_x0.
+ * This is because clipping 4 pixels in the dst is equivalent to
+ * clipping 4 * 2 = 8 > 5 in the src.
+ */
+
+ float scale_x = (float) (*src_x1 - *src_x0) / (*dst_x1 - *dst_x0);
+ float scale_y = (float) (*src_y1 - *src_y0) / (*dst_y1 - *dst_y0);
+
+ /* Clip left side */
+ clip_coordinates(mirror_x, src_x0, dst_x0, dst_x1,
+ clip_dst_x0, clip_dst_x1, scale_x, true);
+
+ /* Clip right side */
+ clip_coordinates(mirror_x, src_x1, dst_x1, dst_x0,
+ clip_dst_x1, clip_dst_x0, scale_x, false);
+
+ /* Clip bottom side */
+ clip_coordinates(mirror_y, src_y0, dst_y0, dst_y1,
+ clip_dst_y0, clip_dst_y1, scale_y, true);
+
+ /* Clip top side */
+ clip_coordinates(mirror_y, src_y1, dst_y1, dst_y0,
+ clip_dst_y1, clip_dst_y0, scale_y, false);
+
+ return false;
+}
+
void
iris_blorp_surf_for_resource(struct blorp_surf *surf,
struct pipe_resource *p_res,
iris_format_for_usage(devinfo, info->dst.format,
ISL_SURF_USAGE_RENDER_TARGET_BIT);
- int src_x0 = info->src.box.x;
- int src_x1 = info->src.box.x + info->src.box.width;
- int src_y0 = info->src.box.y;
- int src_y1 = info->src.box.y + info->src.box.height;
- int dst_x0 = info->dst.box.x;
- int dst_x1 = info->dst.box.x + info->dst.box.width;
- int dst_y0 = info->dst.box.y;
- int dst_y1 = info->dst.box.y + info->dst.box.height;
- bool mirror_x = false;
- bool mirror_y = false;
+ float src_x0 = info->src.box.x;
+ float src_x1 = info->src.box.x + info->src.box.width;
+ float src_y0 = info->src.box.y;
+ float src_y1 = info->src.box.y + info->src.box.height;
+ float dst_x0 = info->dst.box.x;
+ float dst_x1 = info->dst.box.x + info->dst.box.width;
+ float dst_y0 = info->dst.box.y;
+ float dst_y1 = info->dst.box.y + info->dst.box.height;
+ bool mirror_x = apply_mirror(&src_x0, &src_x1);
+ bool mirror_y = apply_mirror(&src_y0, &src_y1);
enum blorp_filter filter;
+ if (info->scissor_enable) {
+ bool noop = apply_blit_scissor(&info->scissor,
+ &src_x0, &src_y0, &src_x1, &src_y1,
+ &dst_x0, &dst_y0, &dst_x1, &dst_y1,
+ mirror_x, mirror_y);
+ if (noop)
+ return;
+ }
+
if (abs(info->dst.box.width) == abs(info->src.box.width) &&
abs(info->dst.box.height) == abs(info->src.box.height)) {
if (src_surf.surf->samples > 1 && dst_surf.surf->samples <= 1) {
projects / mesa.git / commitdiff