i965: Extend the negative 32-bit deltas to 64-bits
authorSergii Romantsov <sergii.romantsov@gmail.com>
Mon, 2 Apr 2018 06:59:06 +0000 (09:59 +0300)
committerKenneth Graunke <kenneth@whitecape.org>
Wed, 4 Apr 2018 05:48:09 +0000 (22:48 -0700)
Gen8+ use 48-bit address relocations so need to extend the sign
to 64-bit return value. Without it we have higher bits zeroed
and missing the negavive values.
Haswell and older use 32-bit deltas so are unaffected by this issue.

v2:
  used int32_t fucntion parameter instead of explicit type conversion.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101408
Signed-off-by: Sergii Romantsov <sergii.romantsov@globallogic.com>
Tested-by: Andriy Khulap <andriy.khulap@globallogic.com>
Tested-by: Stuart Young <cefiar@gmail.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Cc: "18.0 17.3" <mesa-stable@lists.freedesktop.org>
src/mesa/drivers/dri/i965/intel_batchbuffer.c

index ebc02ff3897938e51399eb5538b507e3c36e680f..7286140bcc9b569dbc094a984ace09596400bcb3 100644 (file)
@@ -1079,7 +1079,7 @@ brw_batch_references(struct intel_batchbuffer *batch, struct brw_bo *bo)
 static uint64_t
 emit_reloc(struct intel_batchbuffer *batch,
            struct brw_reloc_list *rlist, uint32_t offset,
-           struct brw_bo *target, uint32_t target_offset,
+           struct brw_bo *target, int32_t target_offset,
            unsigned int reloc_flags)
 {
    assert(target != NULL);