* buildsym.c (block_compar): Fix comment.
authorDoug Evans <dje@google.com>
Tue, 29 May 2012 20:23:17 +0000 (20:23 +0000)
committerDoug Evans <dje@google.com>
Tue, 29 May 2012 20:23:17 +0000 (20:23 +0000)
(end_symtab): Fix and clarify some comments.

gdb/ChangeLog
gdb/buildsym.c

index b550855c90764663a3dc1f8ca34f4c7933e28fb0..b199f875cbc4af83d884f2abc9f87f9b8dd3a38f 100644 (file)
@@ -1,5 +1,8 @@
 2012-05-29  Doug Evans  <dje@google.com>
 
+       * buildsym.c (block_compar): Fix comment.
+       (end_symtab): Fix and clarify some comments.
+
        * stabsread.h (cleanup_undefined_stabs_types): Renamed from
        cleanup_undefined_types.
        * stabsread.c (cleanup_undefined_stabs_types): Ditto.
index d41f26d88d49dc111d0d78b5bb591d4580df1934..20fabb7fbc028d75b04d82f211e97b4ca0775e22 100644 (file)
@@ -907,7 +907,7 @@ watch_main_source_file_lossage (void)
     }
 }
 
-/* Helper function for qsort.  Parametes are `struct block *' pointers,
+/* Helper function for qsort.  Parameters are `struct block *' pointers,
    function sorts them in descending order by their BLOCK_START.  */
 
 static int
@@ -1126,7 +1126,7 @@ end_symtab (CORE_ADDR end_addr, struct objfile *objfile, int section)
             {
               /* Since we are ignoring that subfile, we also need
                  to unlink the associated empty symtab that we created.
-                 Otherwise, we can into trouble because various parts
+                 Otherwise, we can run into trouble because various parts
                  such as the block-vector are uninitialized whereas
                  the rest of the code assumes that they are.
                  
@@ -1196,7 +1196,8 @@ end_symtab (CORE_ADDR end_addr, struct objfile *objfile, int section)
              SYMBOL_SYMTAB (BLOCK_FUNCTION (block)) = symtab;
 
          /* Note that we only want to fix up symbols from the local
-            blocks, not blocks coming from included symtabs.  */
+            blocks, not blocks coming from included symtabs.  That is why
+            we use ALL_DICT_SYMBOLS here and not ALL_BLOCK_SYMBOLS.  */
          ALL_DICT_SYMBOLS (BLOCK_DICT (block), iter, sym)
            if (SYMBOL_SYMTAB (sym) == NULL)
              SYMBOL_SYMTAB (sym) = symtab;