x86/Intel: drop unnecessary bracket matching from parse_operands()

While subsequent processing in AT&T mode relies on this simplistic early
checking, Intel mode hasn't been for quite a long time (or perhaps never
really did).

diff --git a/gas/ChangeLog b/gas/ChangeLog
index 2f11767b5bec686e4ab2dbc72899652244b3ca52..66e040aaa149afc260172dae4f8cd2f8661cd0f7 100644 (file)
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,8 @@
+2021-06-07  Jan Beulich  <jbeulich@suse.com>
+
+       * config/tc-i386.c (parse_operands): Don't check for matched
+       square brackets.
+
 2021-06-07  Jan Beulich  <jbeulich@suse.com>
 
        * config/tc-i386.c (check_VecOperations): Remove 2nd parameter.

diff --git a/gas/config/tc-i386.c b/gas/config/tc-i386.c
index 3a59ea086ac38267982e56a821a18508aefcc3e8..a20aea287182c99b589ee343decf188433a77217 100644 (file)
--- a/gas/config/tc-i386.c
+++ b/gas/config/tc-i386.c
@@ -5556,12 +5556,9 @@ parse_operands (char *l, const char *mnemonic)
            {
              if (paren_not_balanced)
                {
-                 if (!intel_syntax)
-                   as_bad (_("unbalanced parenthesis in operand %d."),
-                           i.operands + 1);
-                 else
-                   as_bad (_("unbalanced brackets in operand %d."),
-                           i.operands + 1);
+                 know (!intel_syntax);
+                 as_bad (_("unbalanced parenthesis in operand %d."),
+                         i.operands + 1);
                  return NULL;
                }
              else
@@ -5581,13 +5578,6 @@ parse_operands (char *l, const char *mnemonic)
              if (*l == ')')
                --paren_not_balanced;
            }
-         else
-           {
-             if (*l == '[')
-               ++paren_not_balanced;
-             if (*l == ']')
-               --paren_not_balanced;
-           }
          l++;
        }
       if (l != token_start)