Use a previously unused variable in bfin-tdep.c

This changes bfin_push_dummy_call to use the result of check_typedef.
Calling check_typedef for effect was probably ok as well, but this
seemed a little nicer.

gdb/ChangeLog
2018-07-22  Tom Tromey  <tom@tromey.com>

	* bfin-tdep.c (bfin_push_dummy_call): Use arg_type, not
	value_type.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 224d91ded29291afb183af6cfdbaac19d16e6f66..8eb2cde80f7e2a122ba12704f033a9cbc96321ea 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2018-07-22  Tom Tromey  <tom@tromey.com>
+
+       * bfin-tdep.c (bfin_push_dummy_call): Use arg_type, not
+       value_type.
+
 2018-07-22  Tom Tromey  <tom@tromey.com>
 
        * windows-nat.c (saved_context): Conditionally define.

diff --git a/gdb/bfin-tdep.c b/gdb/bfin-tdep.c
index da62130231bc25d0964fc883ef07e4c3540444bf..c84625c89480a738695e74deb8f9e39496a3fcfe 100644 (file)
--- a/gdb/bfin-tdep.c
+++ b/gdb/bfin-tdep.c
@@ -526,7 +526,7 @@ bfin_push_dummy_call (struct gdbarch *gdbarch,
     {
       struct type *value_type = value_enclosing_type (args[i]);
       struct type *arg_type = check_typedef (value_type);
-      int container_len = (TYPE_LENGTH (value_type) + 3) & ~3;
+      int container_len = (TYPE_LENGTH (arg_type) + 3) & ~3;
 
       sp -= container_len;
       write_memory (sp, value_contents (args[i]), container_len);