toolchain/helpers.mk: fix creation of DESTDIR in copy_toolchain_lib_root
authorArnout Vandecappelle <arnout@mind.be>
Wed, 5 Jul 2017 14:54:18 +0000 (16:54 +0200)
committerThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Wed, 5 Jul 2017 16:10:46 +0000 (18:10 +0200)
In commit b3cc7e65ee, the definition of the DESTDIR variable was moved
down into the loop that follows symlinks in the libraries that are
copied to target. However, the corresponding mkdir was not moved down,
so that no directories are ever created.

In practice, this mkdir is normally redundant since the directories
should already have been created as part of creating STAGING_DIR.
Still, the current situation is clearly wrong, so fix it by moving the
mkdir down to after the assignment to DESTDIR.

While we're at it, also remove a redundant empty line. It's a leftover
from when a lot of variables were declared above.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
toolchain/helpers.mk

index 6136aef6b9c7e99dcbe28557b0032e4a71ea8599..9942ce404f543b455cac9c2777f7f73bdc4ad462 100644 (file)
 #
 copy_toolchain_lib_root = \
        LIBPATTERN="$(strip $1)"; \
-\
        LIBPATHS=`find $(STAGING_DIR)/ -name "$${LIBPATTERN}" 2>/dev/null` ; \
        for LIBPATH in $${LIBPATHS} ; do \
-               mkdir -p $(TARGET_DIR)/$${DESTDIR}; \
                while true ; do \
                        LIBNAME=`basename $${LIBPATH}`; \
                        DESTDIR=`echo $${LIBPATH} | sed "s,^$(STAGING_DIR)/,," | xargs dirname` ; \
+                       mkdir -p $(TARGET_DIR)/$${DESTDIR}; \
                        rm -fr $(TARGET_DIR)/$${DESTDIR}/$${LIBNAME}; \
                        if test -h $${LIBPATH} ; then \
                                cp -d $${LIBPATH} $(TARGET_DIR)/$${DESTDIR}/$${LIBNAME}; \