re PR tree-optimization/86010 (redundant memset with smaller size not eliminated)

	PR tree-optimization/86010
	* tree-ssa-dse.c (compute_trims): More aggressively trim at
	both the head and tail of mem* and str* calls.

From-SVN: r262464

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 22991846d52542b368f2316b933cc41bb2f97c0a..61fc28f076e6b7b112f1f4bb659a311e2b054793 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2018-07-05  Jeff Law  <law@redhat.com>
+
+       PR tree-optimization/86010
+       * tree-ssa-dse.c (compute_trims): More aggressively trim at
+       both the head and tail of mem* and str* calls.
+
 2018-07-05  Jim Wilson  <jimw@sifive.com>
 
        * config.gcc (riscv*-*-*): When setting xlen, handle riscv-*.

diff --git a/gcc/tree-ssa-dse.c b/gcc/tree-ssa-dse.c
index 1af50a0267422990a4b752200fa67753bb20e249..ebc4a1e0fc1721a0b7e3c9eed0e982463ce18ce5 100644 (file)
--- a/gcc/tree-ssa-dse.c
+++ b/gcc/tree-ssa-dse.c
@@ -240,11 +240,14 @@ compute_trims (ao_ref *ref, sbitmap live, int *trim_head, int *trim_tail,
 
   /* Now identify how much, if any of the tail we can chop off.  */
   HOST_WIDE_INT const_size;
+  int last_live = bitmap_last_set_bit (live);
   if (ref->size.is_constant (&const_size))
     {
       int last_orig = (const_size / BITS_PER_UNIT) - 1;
-      int last_live = bitmap_last_set_bit (live);
-      *trim_tail = (last_orig - last_live) & ~0x1;
+      /* We can leave inconvenient amounts on the tail as
+        residual handling in mem* and str* functions is usually
+        reasonably efficient.  */
+      *trim_tail = last_orig - last_live;
     }
   else
     *trim_tail = 0;
@@ -252,7 +255,12 @@ compute_trims (ao_ref *ref, sbitmap live, int *trim_head, int *trim_tail,
   /* Identify how much, if any of the head we can chop off.  */
   int first_orig = 0;
   int first_live = bitmap_first_set_bit (live);
-  *trim_head = (first_live - first_orig) & ~0x1;
+  *trim_head = first_live - first_orig;
+
+  /* If more than a word remains, then make sure to keep the
+     starting point at least word aligned.  */
+  if (last_live - first_live > UNITS_PER_WORD)
+    *trim_head &= (UNITS_PER_WORD - 1);
 
   if ((*trim_head || *trim_tail)
       && dump_file && (dump_flags & TDF_DETAILS))