-Wwrite-strings: execute_command calls with string literals

This is ugly, but it's just making the uglyness explicit.

All these places would better be calling some API function directly
instead of going through execute_command & friends...

gdb/ChangeLog:
2017-04-05  Pedro Alves  <palves@redhat.com>

	* event-top.c (command_line_handler): Add cast to execute_command
	call.
	* record-btrace.c (cmd_record_btrace_bts_start)
	(cmd_record_btrace_pt_start, cmd_record_btrace_start)
	(cmd_record_btrace_start): Add cast to execute_command call.
	* record-full.c (record_full_goto_insn):
	* record.c (record_start, record_stop): Add cast to
	execute_command_to_string calls.
	(cmd_record_start): Add cast to execute_command calls.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 610a1d04abf20abfa554c97a792b8a2d0e14457a..26899e471baa1e8b49d23ee8422ab28df3c4fb06 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,15 @@
+2017-04-05  Pedro Alves  <palves@redhat.com>
+
+       * event-top.c (command_line_handler): Add cast to execute_command
+       call.
+       * record-btrace.c (cmd_record_btrace_bts_start)
+       (cmd_record_btrace_pt_start, cmd_record_btrace_start)
+       (cmd_record_btrace_start): Add cast to execute_command call.
+       * record-full.c (record_full_goto_insn):
+       * record.c (record_start, record_stop): Add cast to
+       execute_command_to_string calls.
+       (cmd_record_start): Add cast to execute_command calls.
+
 2017-04-05  Pedro Alves  <palves@redhat.com>
 
        * python/python-internal.h (gdb_PyArg_ParseTupleAndKeywords): New

diff --git a/gdb/event-top.c b/gdb/event-top.c
index 5d8d077a9a44a1209d37ed26092d8f3617857241..dd2770a8806624c574af3ef86df92979a0b58633 100644 (file)
--- a/gdb/event-top.c
+++ b/gdb/event-top.c
@@ -766,7 +766,7 @@ command_line_handler (char *rl)
         hung up but GDB is still alive.  In such a case, we just quit
         gdb killing the inferior program too.  */
       printf_unfiltered ("quit\n");
-      execute_command ("quit", 1);
+      execute_command ((char *) "quit", 1);
     }
   else if (cmd == NULL)
     {

diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c
index af025e2a1caaf47be5638551a8c59b707e939daf..61fba1e46f3272228908e0b3b10f96601076337b 100644 (file)
--- a/gdb/record-btrace.c
+++ b/gdb/record-btrace.c
@@ -2897,7 +2897,7 @@ cmd_record_btrace_bts_start (char *args, int from_tty)
 
   TRY
     {
-      execute_command ("target record-btrace", from_tty);
+      execute_command ((char *) "target record-btrace", from_tty);
     }
   CATCH (exception, RETURN_MASK_ALL)
     {
@@ -2919,7 +2919,7 @@ cmd_record_btrace_pt_start (char *args, int from_tty)
 
   TRY
     {
-      execute_command ("target record-btrace", from_tty);
+      execute_command ((char *) "target record-btrace", from_tty);
     }
   CATCH (exception, RETURN_MASK_ALL)
     {
@@ -2941,7 +2941,7 @@ cmd_record_btrace_start (char *args, int from_tty)
 
   TRY
     {
-      execute_command ("target record-btrace", from_tty);
+      execute_command ((char *) "target record-btrace", from_tty);
     }
   CATCH (exception, RETURN_MASK_ALL)
     {
@@ -2949,7 +2949,7 @@ cmd_record_btrace_start (char *args, int from_tty)
 
       TRY
        {
-         execute_command ("target record-btrace", from_tty);
+         execute_command ((char *) "target record-btrace", from_tty);
        }
       CATCH (exception, RETURN_MASK_ALL)
        {

diff --git a/gdb/record-full.c b/gdb/record-full.c
index bd95acc6b1854753eb5da541cd7934eb3b8c9113..31ff558d2a633cff71d3e6082e42f5d6fb88bcf1 100644 (file)
--- a/gdb/record-full.c
+++ b/gdb/record-full.c
@@ -2788,7 +2788,7 @@ record_full_goto_insn (struct record_full_entry *entry,
 static void
 cmd_record_full_start (char *args, int from_tty)
 {
-  execute_command ("target record-full", from_tty);
+  execute_command ((char *) "target record-full", from_tty);
 }
 
 static void

diff --git a/gdb/record.c b/gdb/record.c
index eff8fe10e19e89f4a493a527d43cd8c61900e6ac..16e5b03fe84658be9a37da4a243dbfaa616908e1 100644 (file)
--- a/gdb/record.c
+++ b/gdb/record.c
@@ -99,25 +99,25 @@ record_start (const char *method, const char *format, int from_tty)
   if (method == NULL)
     {
       if (format == NULL)
-       execute_command_to_string ("record", from_tty);
+       execute_command_to_string ((char *) "record", from_tty);
       else
        error (_("Invalid format."));
     }
   else if (strcmp (method, "full") == 0)
     {
       if (format == NULL)
-       execute_command_to_string ("record full", from_tty);
+       execute_command_to_string ((char *) "record full", from_tty);
       else
        error (_("Invalid format."));
     }
   else if (strcmp (method, "btrace") == 0)
     {
       if (format == NULL)
-       execute_command_to_string ("record btrace", from_tty);
+       execute_command_to_string ((char *) "record btrace", from_tty);
       else if (strcmp (format, "bts") == 0)
-       execute_command_to_string ("record btrace bts", from_tty);
+       execute_command_to_string ((char *) "record btrace bts", from_tty);
       else if (strcmp (format, "pt") == 0)
-       execute_command_to_string ("record btrace pt", from_tty);
+       execute_command_to_string ((char *) "record btrace pt", from_tty);
       else
        error (_("Invalid format."));
     }
@@ -130,7 +130,7 @@ record_start (const char *method, const char *format, int from_tty)
 void
 record_stop (int from_tty)
 {
-  execute_command_to_string ("record stop", from_tty);
+  execute_command_to_string ((char *) "record stop", from_tty);
 }
 
 /* See record.h.  */
@@ -265,7 +265,7 @@ show_record_debug (struct ui_file *file, int from_tty,
 static void
 cmd_record_start (char *args, int from_tty)
 {
-  execute_command ("target record-full", from_tty);
+  execute_command ((char *) "target record-full", from_tty);
 }
 
 /* Truncate the record log from the present point