Use -Bsymbolic when linking libEGL.so
authorCarl Worth <cworth@cworth.org>
Fri, 27 Sep 2013 21:01:48 +0000 (14:01 -0700)
committerCarl Worth <cworth@cworth.org>
Mon, 30 Sep 2013 22:49:16 +0000 (15:49 -0700)
For some reason that I don't yet fully understand, Glaze does not work with
libEGL unless libEGL is linked with -Bsymbolic.[*]

Beyond that specific reason, all of the reasons for which libGL.so is linked
with -Bsymbolic, (see the commit history), should also apply here.

[*] The specific behavior I am seeing is that when Glaze calls dlopen for
libEGL.so, ifunc resolvers within Glaze for EGL functions are called before
the dlopen returns. These resolvers cannot succeed, as they need the return
value from dlopen in order to find the functions to resolve to. I don't know
what's causing these resolvers to be called, but I have verified that linking
libEGL with -Bsymbolic causes this problematic behavior to stop.

CC: "9.1 and 9.2" <mesa-stable@lists.freedesktop.org>
Reviewed-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Chad Versace <chad.versace@linux.intel.com>
src/egl/main/Makefile.am

index 2e438601544762cf807d6c24a219f9f95feb694f..786406aa71a26d9e23c5de294fec38af281bf1bb 100644 (file)
@@ -73,7 +73,7 @@ libEGL_la_SOURCES = \
 
 libEGL_la_LIBADD = \
        $(EGL_LIB_DEPS)
-libEGL_la_LDFLAGS = -version-number 1:0 -no-undefined
+libEGL_la_LDFLAGS = -Wl,-Bsymbolic -version-number 1:0 -no-undefined
 
 if HAVE_EGL_PLATFORM_X11
 AM_CFLAGS += -DHAVE_X11_PLATFORM