Fix incorrect TARGET_MEM_REF alignment (PR 84419)

expand_call_mem_ref checks for TARGET_MEM_REFs that have compatible
type, but it didn't then go on to install the specific type we need,
which might have different alignment due to:

  if (TYPE_ALIGN (type) != align)
    type = build_aligned_type (type, align);

This was causing masked stores to be incorrectly marked as
aligned on AVX512.

2018-02-20  Richard Sandiford  <richard.sandiford@linaro.org>

gcc/
	PR tree-optimization/84419
	* internal-fn.c (expand_call_mem_ref): Create a TARGET_MEM_REF
	with the required type if its current type is compatible but
	different.

gcc/testsuite/
	PR tree-optimization/84419
	* gcc.dg/vect/pr84419.c: New test.

From-SVN: r257847

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index b485a9252682a4a7395f6b52c7de0fe63051e300..2c679c9436e20220c5003dd7979e29caebef9137 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,10 @@
+2018-02-20  Richard Sandiford  <richard.sandiford@linaro.org>
+
+       PR tree-optimization/84419
+       * internal-fn.c (expand_call_mem_ref): Create a TARGET_MEM_REF
+       with the required type if its current type is compatible but
+       different.
+
 2018-02-20  Jakub Jelinek  <jakub@redhat.com>
 
        PR middle-end/82004

diff --git a/gcc/internal-fn.c b/gcc/internal-fn.c
index 88adaea4c862572b913b1e3db32571e61cf78027..da205c9d68a16217f9e8e575206fec5d3456934e 100644 (file)
--- a/gcc/internal-fn.c
+++ b/gcc/internal-fn.c
@@ -2444,11 +2444,14 @@ expand_call_mem_ref (tree type, gcall *stmt, int index)
          && types_compatible_p (TREE_TYPE (mem), type))
        {
          tree offset = TMR_OFFSET (mem);
-         if (alias_ptr_type != TREE_TYPE (offset) || !integer_zerop (offset))
+         if (type != TREE_TYPE (mem)
+             || alias_ptr_type != TREE_TYPE (offset)
+             || !integer_zerop (offset))
            {
              mem = copy_node (mem);
              TMR_OFFSET (mem) = wide_int_to_tree (alias_ptr_type,
                                                   wi::to_poly_wide (offset));
+             TREE_TYPE (mem) = type;
            }
          return mem;
        }

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 95f06bf66d270d46e5699cd42462dc149e3c93a2..8eb50db74788ab2538429a641bb6d7425bb11e69 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2018-02-20  Richard Sandiford  <richard.sandiford@linaro.org>
+
+       PR tree-optimization/84419
+       * gcc.dg/vect/pr84419.c: New test.
+
 2018-02-20  Jakub Jelinek  <jakub@redhat.com>
 
        PR middle-end/82004

diff --git a/gcc/testsuite/gcc.dg/vect/pr84419.c b/gcc/testsuite/gcc.dg/vect/pr84419.c
new file mode 100644 (file)
index 0000000..4864f8e
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/vect/pr84419.c
@@ -0,0 +1,21 @@
+#include <string.h>
+
+#define SIZE 400
+
+int  foo[SIZE];
+char bar[SIZE];
+
+void __attribute__ ((noinline)) foo_func(void)
+{
+  int i;
+  for (i = 1; i < SIZE; i++)
+    if (bar[i])
+      foo[i] = 1;
+}
+
+int main()
+{
+  memset(bar, 1, sizeof(bar));
+  foo_func();
+  return 0;
+}