radv/aco: enable VK_KHR_subgroup_extended_types on GFX8+

Should be working now.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5148>

diff --git a/docs/relnotes/new_features.txt b/docs/relnotes/new_features.txt
index 1e86e1535456c0a0ae9a8791d27e1f14d9dc5dc9..710318cc7faa8b6f89b27f9c1b23dda562019d0c 100644 (file)
--- a/docs/relnotes/new_features.txt
+++ b/docs/relnotes/new_features.txt
@@ -5,3 +5,4 @@ VK_EXT_custom_border_color on RADV.
 VK_EXT_pipeline_creation_cache_control on RADV.
 VK_EXT_subgroup_size_control on RADV/ACO.
 VK_GOOGLE_user_type on ANV and RADV.
+VK_KHR_subgroup_extended_types on RADV/ACO.

diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 6b8ab29d5a95e0dd80fe9dabe3d807579ce6df59..c4493d01788caa8a8a46ea07eb111a85195028e2 100644 (file)
--- a/src/amd/vulkan/radv_device.c
+++ b/src/amd/vulkan/radv_device.c
@@ -1011,7 +1011,7 @@ radv_get_physical_device_features_1_2(struct radv_physical_device *pdevice,
        f->scalarBlockLayout = pdevice->rad_info.chip_class >= GFX7;
        f->imagelessFramebuffer = true;
        f->uniformBufferStandardLayout = true;
-       f->shaderSubgroupExtendedTypes = !pdevice->use_aco;
+       f->shaderSubgroupExtendedTypes = !pdevice->use_aco || pdevice->rad_info.chip_class >= GFX8;
        f->separateDepthStencilLayouts = true;
        f->hostQueryReset = true;
        f->timelineSemaphore = pdevice->rad_info.has_syncobj_wait_for_submit;

diff --git a/src/amd/vulkan/radv_extensions.py b/src/amd/vulkan/radv_extensions.py
index 1a7fea960bde9c9ab2d408e4705589af04e1cb5f..ea955a136fcfb1e245a0584b1f1d86f8a0db62e8 100644 (file)
--- a/src/amd/vulkan/radv_extensions.py
+++ b/src/amd/vulkan/radv_extensions.py
@@ -100,7 +100,7 @@ EXTENSIONS = [
     Extension('VK_KHR_shader_float_controls',             1, True),
     Extension('VK_KHR_shader_float16_int8',               1, '!device->use_aco || device->rad_info.chip_class >= GFX8'),
     Extension('VK_KHR_shader_non_semantic_info',          1, True),
-    Extension('VK_KHR_shader_subgroup_extended_types',    1, '!device->use_aco'),
+    Extension('VK_KHR_shader_subgroup_extended_types',    1, '!device->use_aco || device->rad_info.chip_class >= GFX8'),
     Extension('VK_KHR_spirv_1_4',                         1, True),
     Extension('VK_KHR_storage_buffer_storage_class',      1, True),
     Extension('VK_KHR_surface',                          25, 'RADV_HAS_SURFACE'),