sim: Remove check whether the System port is connected.
authorGabe Black <gabeblack@google.com>
Sat, 19 Sep 2020 06:07:00 +0000 (23:07 -0700)
committerGabe Black <gabeblack@google.com>
Fri, 25 Sep 2020 23:51:49 +0000 (23:51 +0000)
The port will report an error if something tries to use it and
it's not connected. If it isn't needed, there's no reason to force
users to hook something up to it just to satisfy the check.

Change-Id: I0668b8a86c8cb323aba51670fb7914d35acc5198
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/34815
Maintainer: Gabe Black <gabeblack@google.com>
Tested-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
Reviewed-by: Jason Lowe-Power <power.jg@gmail.com>
Reviewed-by: Andreas Sandberg <andreas.sandberg@arm.com>
src/sim/system.cc
src/sim/system.hh

index cbc30a903431d698aa03838836555700269715ea..39b3414a0f6a6f0b7c2b68365ba6d03bd6f6ec6c 100644 (file)
@@ -272,14 +272,6 @@ System::~System()
         delete workItemStats[j];
 }
 
-void
-System::init()
-{
-    // check that the system port is connected
-    if (!_systemPort.isConnected())
-        panic("System port on %s is not connected.\n", name());
-}
-
 void
 System::startup()
 {
index fc93b85f7f6240a531f27e3b96fa2cf3e385d25d..e5d4ec625644182e609242dc35accd8be313a536 100644 (file)
@@ -221,11 +221,6 @@ class System : public SimObject, public PCEventScope
         const_iterator end() const { return const_iterator(*this, size()); }
     };
 
-    /**
-     * After all objects have been created and all ports are
-     * connected, check that the system port is connected.
-     */
-    void init() override;
     void startup() override;
 
     /**