glsl: Make the tree rebalancer use vector_elements, not components().
authorKenneth Graunke <kenneth@whitecape.org>
Tue, 15 Jul 2014 23:36:32 +0000 (16:36 -0700)
committerKenneth Graunke <kenneth@whitecape.org>
Wed, 16 Jul 2014 22:43:13 +0000 (15:43 -0700)
components() includes matrix columns, so if this code encountered a
matrix, it would ask for something like a vec9 or vec16.  This is
clearly not what you want.

Earlier code now prevents this from seeing matrices, but we should still
use vector_elements, for clarity.

Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
src/glsl/opt_rebalance_tree.cpp

index f82b16b5412dde9e7c32b9dff242c6230cb571d2..095f2d7d2f079b7e7a57212de23f3b70388d5eca 100644 (file)
@@ -273,8 +273,8 @@ update_types(ir_instruction *ir, void *)
 
    const glsl_type *const new_type =
       glsl_type::get_instance(expr->type->base_type,
-                              MAX2(expr->operands[0]->type->components(),
-                                   expr->operands[1]->type->components()),
+                              MAX2(expr->operands[0]->type->vector_elements,
+                                   expr->operands[1]->type->vector_elements),
                               1);
    assert(new_type != glsl_type::error_type);
    expr->type = new_type;