convert to_core_of_thread

2014-02-19  Tom Tromey  <tromey@redhat.com>

	* target-delegates.c: Rebuild.
	* target.c (target_core_of_thread): Unconditionally delegate.
	* target.h (struct target_ops) <to_core_of_thread>: Use
	TARGET_DEFAULT_RETURN.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 56e62e064360f8488b3c4157ce1f12e070cffe8e..7c489a9e7f6f9739dd95a6ef81f1ae291701f3eb 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2014-02-19  Tom Tromey  <tromey@redhat.com>
+
+       * target-delegates.c: Rebuild.
+       * target.c (target_core_of_thread): Unconditionally delegate.
+       * target.h (struct target_ops) <to_core_of_thread>: Use
+       TARGET_DEFAULT_RETURN.
+
 2014-02-19  Tom Tromey  <tromey@redhat.com>
 
        * target-delegates.c: Rebuild.

diff --git a/gdb/target-delegates.c b/gdb/target-delegates.c
index 94117b88123f54825f0d31210dbbfb10e5a9deb2..2c7ab7f73f2303087230f5f56e24c75a05d97e1e 100644 (file)
--- a/gdb/target-delegates.c
+++ b/gdb/target-delegates.c
@@ -1131,6 +1131,19 @@ tdefault_set_trace_notes (struct target_ops *self, const char *arg1, const char
   return 0;
 }
 
+static int
+delegate_core_of_thread (struct target_ops *self, ptid_t arg1)
+{
+  self = self->beneath;
+  return self->to_core_of_thread (self, arg1);
+}
+
+static int
+tdefault_core_of_thread (struct target_ops *self, ptid_t arg1)
+{
+  return -1;
+}
+
 static int
 delegate_get_tib_address (struct target_ops *self, ptid_t arg1, CORE_ADDR *arg2)
 {
@@ -1442,6 +1455,8 @@ install_delegators (struct target_ops *ops)
     ops->to_set_trace_buffer_size = delegate_set_trace_buffer_size;
   if (ops->to_set_trace_notes == NULL)
     ops->to_set_trace_notes = delegate_set_trace_notes;
+  if (ops->to_core_of_thread == NULL)
+    ops->to_core_of_thread = delegate_core_of_thread;
   if (ops->to_get_tib_address == NULL)
     ops->to_get_tib_address = delegate_get_tib_address;
   if (ops->to_set_permissions == NULL)
@@ -1561,6 +1576,7 @@ install_dummy_methods (struct target_ops *ops)
   ops->to_set_circular_trace_buffer = tdefault_set_circular_trace_buffer;
   ops->to_set_trace_buffer_size = tdefault_set_trace_buffer_size;
   ops->to_set_trace_notes = tdefault_set_trace_notes;
+  ops->to_core_of_thread = tdefault_core_of_thread;
   ops->to_get_tib_address = tdefault_get_tib_address;
   ops->to_set_permissions = tdefault_set_permissions;
   ops->to_static_tracepoint_marker_at = tdefault_static_tracepoint_marker_at;

diff --git a/gdb/target.c b/gdb/target.c
index d96f706a9676979788dda4b6934e719c40a795ba..5f86c4ef1973f654aa0a4591cab4da899296a4f0 100644 (file)
--- a/gdb/target.c
+++ b/gdb/target.c
@@ -3711,23 +3711,13 @@ target_store_registers (struct regcache *regcache, int regno)
 int
 target_core_of_thread (ptid_t ptid)
 {
-  struct target_ops *t;
-
-  for (t = current_target.beneath; t != NULL; t = t->beneath)
-    {
-      if (t->to_core_of_thread != NULL)
-       {
-         int retval = t->to_core_of_thread (t, ptid);
-
-         if (targetdebug)
-           fprintf_unfiltered (gdb_stdlog,
-                               "target_core_of_thread (%d) = %d\n",
-                               ptid_get_pid (ptid), retval);
-         return retval;
-       }
-    }
+  int retval = current_target.to_core_of_thread (&current_target, ptid);
 
-  return -1;
+  if (targetdebug)
+    fprintf_unfiltered (gdb_stdlog,
+                       "target_core_of_thread (%d) = %d\n",
+                       ptid_get_pid (ptid), retval);
+  return retval;
 }
 
 int

diff --git a/gdb/target.h b/gdb/target.h
index cb0bed2d722e4948e2bbc3cf69ab81efc93df701..0a6c467fa9f7f86ab68a0cb8ba1b5ab541f1ab15 100644 (file)
--- a/gdb/target.h
+++ b/gdb/target.h
@@ -933,7 +933,8 @@ struct target_ops
        If the core cannot be determined -- either for the specified
        thread, or right now, or in this debug session, or for this
        target -- return -1.  */
-    int (*to_core_of_thread) (struct target_ops *, ptid_t ptid);
+    int (*to_core_of_thread) (struct target_ops *, ptid_t ptid)
+      TARGET_DEFAULT_RETURN (-1);
 
     /* Verify that the memory in the [MEMADDR, MEMADDR+SIZE) range
        matches the contents of [DATA,DATA+SIZE).  Returns 1 if there's