Fix off-by-one error in complaint_internal

complaint_internal had an off-by-one error, where it would allow one
extra complaint to be issued.

gdb/ChangeLog
2018-10-04  Tom Tromey  <tom@tromey.com>

	* complaints.c (complaint_internal): Correctly check complaint
	count.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 5ee22e6d2373bacebbc4cba06abc4972ba73d000..14ef35f68a0f42884267b961006e21d37ebaf08c 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2018-10-04  Tom Tromey  <tom@tromey.com>
+
+       * complaints.c (complaint_internal): Correctly check complaint
+       count.
+
 2018-10-04  Tom Tromey  <tom@tromey.com>
 
        * complaints.h (struct complaints): Remove declaration.

diff --git a/gdb/complaints.c b/gdb/complaints.c
index 03102f13ab3d2d14a6b3e409ae16b7fb0137c3fe..43ea7a18a7386ddd1a03da6e026018760b8e86cf 100644 (file)
--- a/gdb/complaints.c
+++ b/gdb/complaints.c
@@ -56,7 +56,7 @@ complaint_internal (const char *fmt, ...)
 {
   va_list args;
 
-  if (counters[fmt]++ > stop_whining)
+  if (++counters[fmt] > stop_whining)
     return;
 
   va_start (args, fmt);