llvmpipe: Fix bad refactoring.
authorJosé Fonseca <jfonseca@vmware.com>
Sun, 17 Oct 2010 16:58:04 +0000 (09:58 -0700)
committerJosé Fonseca <jfonseca@vmware.com>
Sun, 17 Oct 2010 16:58:04 +0000 (09:58 -0700)
'i' and 'chan' have random values here, which could cause a buffer
overflow in debug builds, if chan > 4.

src/gallium/drivers/llvmpipe/lp_state_fs.c

index c070b55d3d101d913d7559d10775ba9eba260372..7acbe7e86c3e436a9d60f959d08955adfd9d5eaa 100644 (file)
@@ -365,8 +365,7 @@ generate_fs(struct llvmpipe_context *lp,
                                          0);
          
       if (pos0 != -1 && outputs[pos0][2]) {
-         z = LLVMBuildLoad(builder, outputs[pos0][2], "z");
-         lp_build_name(z, "output%u.%u.%c", i, pos0, "xyzw"[chan]);
+         z = LLVMBuildLoad(builder, outputs[pos0][2], "output.z");
       }
 
       lp_build_depth_stencil_test(builder,