ubsan: arc: shift exponent 32 is too large for 32-bit type 'int'

When operand->bits is 32, the following results in UB.
value = (insn >> operand->shift) & ((1 << operand->bits) - 1);

	* arc-dis.c (find_format_from_table): Use ull constant when
	shifting by up to 32.

diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog
index 3460b3e2d605e7a8eceabe44afb4c4beecf046b5..d3f1e69940668d92601a1eeb5fa39accd8457519 100644 (file)
--- a/opcodes/ChangeLog
+++ b/opcodes/ChangeLog
@@ -1,3 +1,8 @@
+2019-12-11  Alan Modra  <amodra@gmail.com>
+
+       * arc-dis.c (find_format_from_table): Use ull constant when
+       shifting by up to 32.
+
 2019-12-11  Alan Modra  <amodra@gmail.com>
 
        PR 25270

diff --git a/opcodes/arc-dis.c b/opcodes/arc-dis.c
index 3c88c334283717103d100d31782e6da4a83388f9..a038fa0ca27f26445f886f8cb87b8313dcce412a 100644 (file)
--- a/opcodes/arc-dis.c
+++ b/opcodes/arc-dis.c
@@ -295,7 +295,7 @@ find_format_from_table (struct disassemble_info *info,
          if (operand->extract)
            value = (*operand->extract) (insn, &invalid);
          else
-           value = (insn >> operand->shift) & ((1 << operand->bits) - 1);
+           value = (insn >> operand->shift) & ((1ull << operand->bits) - 1);
 
          /* Check for LIMM indicator.  If it is there, then make sure
             we pick the right format.  */