Uninitialised memory read in z80-dis.c

objdump -d -m ez80-adl testcase:
 .byte 0x40,0xfd

	* z80-dis.c (suffix): Init mybuf.

diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog
index 4c05e849daf5037899be53d4d64f5efba54258b3..bdfccbac78c8d8c3539e4a60ca36ef5b87b179b7 100644 (file)
--- a/opcodes/ChangeLog
+++ b/opcodes/ChangeLog
@@ -1,3 +1,7 @@
+2020-03-25  Alan Modra  <amodra@gmail.com>
+
+       * z80-dis.c (suffix): Init mybuf.
+
 2020-03-22  Alan Modra  <amodra@gmail.com>
 
        * h8300-dis.c (bfd_h8_disassemble): Limit data[] access to that

diff --git a/opcodes/z80-dis.c b/opcodes/z80-dis.c
index b23e8e99fd8fcffc4e55e5ade070c3e5609ed699..cd840444511fe7a01b6d242f013855090b559b82 100644 (file)
--- a/opcodes/z80-dis.c
+++ b/opcodes/z80-dis.c
@@ -804,6 +804,7 @@ suffix (struct buffer *buf, disassemble_info *info, const char *txt)
   old_stream = info->stream;
   info->fprintf_func = (fprintf_ftype) &sprintf;
   info->stream = mybuf;
+  mybuf[0] = 0;
   buf->base++;
   if (print_insn_z80_buf (buf, info) >= 0)
     buf->n_used++;