intel/fs: Assert that the gen4-6 plane restrictions are followed
authorJason Ekstrand <jason.ekstrand@intel.com>
Thu, 17 May 2018 00:30:04 +0000 (17:30 -0700)
committerJason Ekstrand <jason.ekstrand@intel.com>
Tue, 29 May 2018 22:44:50 +0000 (15:44 -0700)
The fall-back does not work correctly in SIMD16 mode and the register
allocator should ensure that we never hit this case anyway.

Reviewed-by: Matt Turner <mattst88@gmail.com>
src/intel/compiler/brw_fs_generator.cpp

index 6d5306a0eeedccc341ae8e66ba6f7d2602e3e1b2..0c050a73b4c83b1b8ed56f4455122f0ff61251bf 100644 (file)
@@ -817,8 +817,14 @@ fs_generator::generate_linterp(fs_inst *inst,
       }
 
       return true;
-   } else if (devinfo->has_pln &&
-              (devinfo->gen >= 7 || (delta_x.nr & 1) == 0)) {
+   } else if (devinfo->has_pln) {
+      /* From the Sandy Bridge PRM Vol. 4, Pt. 2, Section 8.3.53, "Plane":
+       *
+       *    "[DevSNB]:<src1> must be even register aligned.
+       *
+       * This restriction is lifted on Ivy Bridge.
+       */
+      assert(devinfo->gen >= 7 || (delta_x.nr & 1) == 0);
       brw_PLN(p, dst, interp, delta_x);
 
       return false;