* value.h (common_val_print): Return void.

	* valprint.c (common_val_print): Return void.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 480aa16961a0db8df49275ac722e5c595f782946..643c49c20703e22809ca6918ef35529f9b7f713a 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2012-03-01  Tom Tromey  <tromey@redhat.com>
+
+       * value.h (common_val_print): Return void.
+       * valprint.c (common_val_print): Return void.
+
 2012-03-01  Tom Tromey  <tromey@redhat.com>
 
        * value.h (value_print): Return void.

diff --git a/gdb/valprint.c b/gdb/valprint.c
index 9ff0f27f235968378271751f1cdce0cee8b394f8..a543552916eabed600f9d699ef0282e0257b0fbb 100644 (file)
--- a/gdb/valprint.c
+++ b/gdb/valprint.c
@@ -432,19 +432,16 @@ value_check_printable (struct value *val, struct ui_file *stream,
 /* Print using the given LANGUAGE the value VAL onto stream STREAM according
    to OPTIONS.
 
-   If the data are a string pointer, returns the number of string characters
-   printed.
-
    This is a preferable interface to val_print, above, because it uses
    GDB's value mechanism.  */
 
-int
+void
 common_val_print (struct value *val, struct ui_file *stream, int recurse,
                  const struct value_print_options *options,
                  const struct language_defn *language)
 {
   if (!value_check_printable (val, stream, options))
-    return 0;
+    return;
 
   if (language->la_language == language_ada)
     /* The value might have a dynamic type, which would cause trouble
@@ -453,10 +450,10 @@ common_val_print (struct value *val, struct ui_file *stream, int recurse,
        get a fixed representation of our value.  */
     val = ada_to_fixed_value (val);
 
-  return val_print (value_type (val), value_contents_for_printing (val),
-                   value_embedded_offset (val), value_address (val),
-                   stream, recurse,
-                   val, options, language);
+  val_print (value_type (val), value_contents_for_printing (val),
+            value_embedded_offset (val), value_address (val),
+            stream, recurse,
+            val, options, language);
 }
 
 /* Print on stream STREAM the value VAL according to OPTIONS.  The value

diff --git a/gdb/value.h b/gdb/value.h
index 9706e70216d3b951fd8ae90e201221ae7c50ac5c..bb6f1f61a60eb8bf789858a4ead38040ef304e19 100644 (file)
--- a/gdb/value.h
+++ b/gdb/value.h
@@ -824,10 +824,10 @@ extern int val_print (struct type *type, const gdb_byte *valaddr,
                      const struct value_print_options *options,
                      const struct language_defn *language);
 
-extern int common_val_print (struct value *val,
-                            struct ui_file *stream, int recurse,
-                            const struct value_print_options *options,
-                            const struct language_defn *language);
+extern void common_val_print (struct value *val,
+                             struct ui_file *stream, int recurse,
+                             const struct value_print_options *options,
+                             const struct language_defn *language);
 
 extern int val_print_string (struct type *elttype, const char *encoding,
                             CORE_ADDR addr, int len,