Collections.java (sort): Copy from array in forwards order...

	* java/util/Collections.java (sort):  Copy from array in forwards
	order, rather than reverse order which may be much less efficient.

From-SVN: r88146

diff --git a/libjava/ChangeLog b/libjava/ChangeLog
index 3bf4f1d1e1a73879146d36f4f47d013e4cce3944..2a68a967f5770a7a5542005fb3a6c15a6e18d52d 100644 (file)
--- a/libjava/ChangeLog
+++ b/libjava/ChangeLog
@@ -1,3 +1,8 @@
+2004-09-26  Per Bothner  <per@bothner.com>
+
+       * java/util/Collections.java (sort):  Copy from array in forwards
+       order, rather than reverse order which may be much less efficient.
+
 2004-09-26  Mark Wielaard  <mark@klomp.org>
 
        * java/lang/System.java (properties): Make package private.

diff --git a/libjava/java/util/Collections.java b/libjava/java/util/Collections.java
index d50563c9022383d667d019251d4a86786dc12ee4..d7b5e54e4a87d917aba08015b275a6a09dba0e13 100644 (file)
--- a/libjava/java/util/Collections.java
+++ b/libjava/java/util/Collections.java
@@ -1713,11 +1713,11 @@ public class Collections
   {
     Object[] a = l.toArray();
     Arrays.sort(a, c);
-    ListIterator i = l.listIterator(a.length);
-    for (int pos = a.length; --pos >= 0; )
+    ListIterator i = l.listIterator();
+    for (int pos = 0, alen = a.length;  pos < alen;  pos++)
       {
-       i.previous();
-       i.set(a[pos]);
+        i.next();
+        i.set(a[pos]);
       }
   }