i965: Restore a lost comment about TXF offset bugs.
authorKenneth Graunke <kenneth@whitecape.org>
Mon, 1 Sep 2014 08:36:43 +0000 (01:36 -0700)
committerKenneth Graunke <kenneth@whitecape.org>
Thu, 16 Oct 2014 00:04:27 +0000 (17:04 -0700)
Eric's original code to work around TXF offset bugs contained a comment
explaining the problem, which was lost when Chris generalized it to an
IR transformation (in commit 598ca510b8a118c3c7e18b5d031a2b116120e0a6).

This commit adds the original comment to the newer code.

Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Chris Forbes <chrisf@ijw.co.nz>
src/mesa/drivers/dri/i965/brw_lower_unnormalized_offset.cpp

index c95d7f3cac7265d8a963285e8287a8f6682b6805..8c59b9e415bf2ca90ebc0154c358752e3a3ffae3 100644 (file)
@@ -66,6 +66,11 @@ brw_lower_unnormalized_offset_visitor::visit_leave(ir_texture *ir)
    void *mem_ctx = ralloc_parent(ir);
 
    if (ir->op == ir_txf) {
+      /* It appears that the ld instruction used for txf does its
+       * address bounds check before adding in the offset.  To work
+       * around this, just add the integer offset to the integer texel
+       * coordinate, and don't put the offset in the header.
+       */
       ir_variable *var = new(mem_ctx) ir_variable(ir->coordinate->type,
                                                   "coordinate",
                                                   ir_var_temporary);