re PR c++/28349 (ICE with "undefined" va_arg and references)

2006-08-29  Andrew Pinski  <pinskia@physics.uc.edu>

        PR c++/28349
        * testsuite/g++.dg/warn/var-args1.C: New test.
2006-08-29  Andrew Pinski  <pinskia@physics.uc.edu>

        PR C++/28349
        * call.c (build_x_va_arg): Remove the reference type
        from the type before creating the pointer type.

From-SVN: r116577

diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index 3774c14d33df42f40556ffdf697046d982fc5704..cda27425430a3bc12f994eea64e41b7dd6451c4d 100644 (file)
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,3 +1,9 @@
+2006-08-29  Andrew Pinski  <pinskia@physics.uc.edu>
+
+       PR C++/28349
+       * call.c (build_x_va_arg): Remove the reference type
+       from the type before creating the pointer type.
+
 2006-08-29  J"orn Rennecke  <joern.rennecke@st.com>
 
        PR c++/28139

diff --git a/gcc/cp/call.c b/gcc/cp/call.c
index a91ecd015f8c3f9840fcb1251654d5342d4c168d..7a6646f720092ac16cacc81b0ac1f40c1c1e7b41 100644 (file)
--- a/gcc/cp/call.c
+++ b/gcc/cp/call.c
@@ -4544,10 +4544,12 @@ build_x_va_arg (tree expr, tree type)
 
   if (! pod_type_p (type))
     {
+      /* Remove reference types so we don't ICE later on.  */
+      tree type1 = non_reference (type);
       /* Undefined behavior [expr.call] 5.2.2/7.  */
       warning (0, "cannot receive objects of non-POD type %q#T through %<...%>; "
               "call will abort at runtime", type);
-      expr = convert (build_pointer_type (type), null_node);
+      expr = convert (build_pointer_type (type1), null_node);
       expr = build2 (COMPOUND_EXPR, TREE_TYPE (expr),
                     call_builtin_trap (), expr);
       expr = build_indirect_ref (expr, NULL);

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 6729166449d2b9ef6d73e6fe985495db956af6c1..15f5d63650c6ff5e262cbfafee1f9c077c68d6c8 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2006-08-29  Andrew Pinski  <pinskia@physics.uc.edu>
+
+       PR c++/28349
+       * testsuite/g++.dg/warn/var-args1.C: New test.
+
 2006-08-29  Steven G. Kargl  <kargls@comcast.net>
 
        PR fortran/28866

diff --git a/gcc/testsuite/g++.dg/warn/var-args1.C b/gcc/testsuite/g++.dg/warn/var-args1.C
new file mode 100644 (file)
index 0000000..aadac20
--- /dev/null
+++ b/gcc/testsuite/g++.dg/warn/var-args1.C
@@ -0,0 +1,11 @@
+/* { dg-do compile } */
+
+#include <stdarg.h>
+
+void foo(int, ...)
+{
+    va_list va;
+    int i;
+    i = va_arg(va, int&); /* { dg-warning "cannot receive objects" } */
+}
+