* gdbtypes.h (struct type): Fix comment about what units the

	TYPE_LENGTH is in.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 9902cb1ed3a4e6668e58a7374f5a5b5783e5b28f..a1c99b8896593df41244403b1228f08ee725208e 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+Tue Mar 14 05:52:36 1995  Jim Kingdon  (kingdon@lioth.cygnus.com)
+
+       * gdbtypes.h (struct type): Fix comment about what units the
+       TYPE_LENGTH is in.
+
 Mon Mar 13 18:27:25 1995  Stan Shebs  <shebs@andros.cygnus.com>
 
        * ch-valprint.c (annotate.h): Include.

diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h
index c6b9551fa72c6484edc845d17961183c49d795bb..63a8e530b3a2a197236411375133af164d4887e1 100644 (file)
--- a/gdb/gdbtypes.h
+++ b/gdb/gdbtypes.h
@@ -178,8 +178,16 @@ struct type
 
   char *tag_name;
 
-  /* Length, in units of TARGET_CHAR_BIT bits,
-     of storage for a value of this type */
+  /* Length of storage for a value of this type.  Various places pass
+     this to memcpy and such, meaning it must be in units of
+     HOST_CHAR_BIT.  Various other places expect they can calculate
+     addresses by adding it and such, meaning it must be in units of
+     TARGET_CHAR_BIT.  For some DSP targets, in which HOST_CHAR_BIT
+     will (presumably) be 8 and TARGET_CHAR_BIT will be (say) 32, this
+     is a problem.  One fix would be to make this field in bits
+     (requiring that it always be a multiple of HOST_CHAR_BIT and
+     TARGET_CHAR_BIT)--the other choice would be to make it
+     consistently in units of HOST_CHAR_BIT.  */
 
   unsigned length;