projects / mesa.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: fae7bee)
llvmpipe: Fix bad logic.
authorJosé Fonseca <jfonseca@vmware.com>
Wed, 2 Jun 2010 19:09:02 +0000 (20:09 +0100)
committerJosé Fonseca <jfonseca@vmware.com>
Wed, 2 Jun 2010 20:32:49 +0000 (21:32 +0100)
Courtesy of Vinson and coverity.

src/gallium/drivers/llvmpipe/lp_bld_interp.c patch | blob | history

diff --git a/src/gallium/drivers/llvmpipe/lp_bld_interp.c b/src/gallium/drivers/llvmpipe/lp_bld_interp.c
index 957866e489cf11f5205534f0d01e30ad0bddca21..90d2b26f9f2fa81d549ab8e1c02c4a08a7d3776e 100644 (file)
--- a/src/gallium/drivers/llvmpipe/lp_bld_interp.c
+++ b/src/gallium/drivers/llvmpipe/lp_bld_interp.c
@@ -262,7 +262,7 @@ attribs_update(struct lp_build_interp_soa_context *bld, int quad_index)
       for(chan = 0; chan < NUM_CHANNELS; ++chan) {
          if(mask & (1 << chan)) {
             LLVMValueRef a = coeff_bld->undef;
-            if (interp == LP_INTERP_CONSTANT &&
+            if (interp == LP_INTERP_CONSTANT ||
                 interp == LP_INTERP_FACING) {
                a = bld->a[attrib][chan];
             }