gdb: make macro_stringify return a gdb::unique_xmalloc_ptr<char>

The change to macro_stringify is straightforward.  This allows removing
the manual memory management in fixup_definition.

gdb/ChangeLog:

	* macroexp.h (macro_stringify): Return
	gdb::unique_xmalloc_ptr<char>.
	* macroexp.c (macro_stringify): Likewise.
	* macrotab.c (fixup_definition): Update.

Change-Id: Id7db8988bdbd569dd51c4f4655b00eb26db277cb

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 3cede90590652f5dca1a2455fe2bab2e4fffe1cc..8178e1673b1c4f63e835898be1efc87721c6169a 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2020-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
+
+       * macroexp.h (macro_stringify): Return
+       gdb::unique_xmalloc_ptr<char>.
+       * macroexp.c (macro_stringify): Likewise.
+       * macrotab.c (fixup_definition): Update.
+
 2020-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 
        * c-exp.y (scan_macro_expansion): Don't free `expansion`.

diff --git a/gdb/macroexp.c b/gdb/macroexp.c
index e1d185d30c8e2c65faf2688752fa7cfd8d69dbe2..5f749ffe892855509bff8df3f9b939067870a45a 100644 (file)
--- a/gdb/macroexp.c
+++ b/gdb/macroexp.c
@@ -698,7 +698,7 @@ stringify (struct macro_buffer *dest, const char *arg, int len)
 
 /* See macroexp.h.  */
 
-char *
+gdb::unique_xmalloc_ptr<char>
 macro_stringify (const char *str)
 {
   int len = strlen (str);
@@ -707,7 +707,7 @@ macro_stringify (const char *str)
   stringify (&buffer, str, len);
   buffer.appendc ('\0');
 
-  return buffer.release ().release ();
+  return buffer.release ();
 }
 
 \f

diff --git a/gdb/macroexp.h b/gdb/macroexp.h
index 511991cacd20720df59ea57791ff6d14d2d83712..2e29d02d34bd40efe9adddad01d4361a338f64bf 100644 (file)
--- a/gdb/macroexp.h
+++ b/gdb/macroexp.h
@@ -78,9 +78,7 @@ int macro_is_identifier_nondigit (int c);
 int macro_is_digit (int c);
 
 
-/* Stringify STR according to C rules and return an xmalloc'd pointer
-   to the result.  */
-
-char *macro_stringify (const char *str);
+/* Stringify STR according to C rules and return a null-terminated string.  */
+gdb::unique_xmalloc_ptr<char> macro_stringify (const char *str);
 
 #endif /* MACROEXP_H */

diff --git a/gdb/macrotab.c b/gdb/macrotab.c
index 63cd30148ac24bc539726f70086a36256dc06503..9ada436eaf28bda19ec4c8b6e259797bc2926836 100644 (file)
--- a/gdb/macrotab.c
+++ b/gdb/macrotab.c
@@ -882,25 +882,19 @@ macro_undef (struct macro_source_file *source, int line,
 static struct macro_definition *
 fixup_definition (const char *filename, int line, struct macro_definition *def)
 {
-  static char *saved_expansion;
-
-  if (saved_expansion)
-    {
-      xfree (saved_expansion);
-      saved_expansion = NULL;
-    }
+  static gdb::unique_xmalloc_ptr<char> saved_expansion;
 
   if (def->kind == macro_object_like)
     {
       if (def->argc == macro_FILE)
        {
          saved_expansion = macro_stringify (filename);
-         def->replacement = saved_expansion;
+         def->replacement = saved_expansion.get ();
        }
       else if (def->argc == macro_LINE)
        {
-         saved_expansion = xstrprintf ("%d", line);
-         def->replacement = saved_expansion;
+         saved_expansion.reset (xstrprintf ("%d", line));
+         def->replacement = saved_expansion.get ();
        }
     }