anv: Properly handle all sizes of specialization constants
authorJason Ekstrand <jason@jlekstrand.net>
Wed, 22 Apr 2020 18:41:14 +0000 (13:41 -0500)
committerMarge Bot <eric+marge@anholt.net>
Fri, 24 Apr 2020 09:23:59 +0000 (09:23 +0000)
Closes: #2812
cc: mesa-stable@lists.freedesktop.org

Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4675>

src/intel/vulkan/anv_pipeline.c

index 3eee3b74d842d2254156500459a95e7bb1ed2553..ea2329446667035aa9dbe69c08bcf1ab27fb5044 100644 (file)
@@ -147,10 +147,23 @@ anv_shader_compile_to_nir(struct anv_device *device,
          assert(data + entry.size <= spec_info->pData + spec_info->dataSize);
 
          spec_entries[i].id = spec_info->pMapEntries[i].constantID;
-         if (spec_info->dataSize == 8)
+         switch (entry.size) {
+         case 8:
             spec_entries[i].data64 = *(const uint64_t *)data;
-         else
+            break;
+         case 4:
             spec_entries[i].data32 = *(const uint32_t *)data;
+            break;
+         case 2:
+            spec_entries[i].data32 = *(const uint16_t *)data;
+            break;
+         case 1:
+            spec_entries[i].data32 = *(const uint8_t *)data;
+            break;
+         default:
+            assert(!"Invalid spec constant size");
+            break;
+         }
       }
    }