glsl: remove LowerPrecisionTemporaries

Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6189>

diff --git a/src/compiler/glsl/lower_precision.cpp b/src/compiler/glsl/lower_precision.cpp
index 07798f3b200d18143634f34147a2cbbdfbe66253..1685483bacd35220acb8abb9185ab3a8833bec7b 100644 (file)
--- a/src/compiler/glsl/lower_precision.cpp
+++ b/src/compiler/glsl/lower_precision.cpp
@@ -1333,8 +1333,6 @@ lower_precision(const struct gl_shader_compiler_options *options,
    find_lowerable_rvalues(options, instructions, v.lowerable_rvalues);
    visit_list_elements(&v, instructions);
 
-   if (options->LowerPrecisionTemporaries) {
-      lower_variables_visitor vars(options);
-      visit_list_elements(&vars, instructions);
-   }
+   lower_variables_visitor vars(options);
+   visit_list_elements(&vars, instructions);
 }

diff --git a/src/compiler/glsl/standalone.cpp b/src/compiler/glsl/standalone.cpp
index c1510d51e0b830c864b2e9f707000daa8bcef2fd..ca18700118665f068d394fa3c86848d0eef20bc9 100644 (file)
--- a/src/compiler/glsl/standalone.cpp
+++ b/src/compiler/glsl/standalone.cpp
@@ -441,7 +441,6 @@ standalone_compile_shader(const struct standalone_options *_options,
          options->LowerPrecisionFloat16 = true;
          options->LowerPrecisionInt16 = true;
          options->LowerPrecisionDerivatives = true;
-         options->LowerPrecisionTemporaries = true;
          options->LowerPrecisionConstants = true;
       }
    }

diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h
index 1df6d34b5d4aef22f77a76a9c27926efae08bf5e..f78d2b5d980e33c02c71a4f20c9b02b2308151c7 100644 (file)
--- a/src/mesa/main/mtypes.h
+++ b/src/mesa/main/mtypes.h
@@ -3217,12 +3217,6 @@ struct gl_shader_compiler_options
     */
    GLboolean LowerPrecisionConstants;
 
-   /**
-    * This enables 16-bit phis in NIR, 16-bit loop counters, 16-bit indirect
-    * arrays, etc.
-    */
-   GLboolean LowerPrecisionTemporaries;
-
    /**
     * \name Forms of indirect addressing the driver cannot do.
     */

diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c
index bd6203a1901eb6fcfef28f0c16d4736bf9510d9b..af454dca069dd343a5c0d9c100a6d77f7b19858a 100644 (file)
--- a/src/mesa/state_tracker/st_extensions.c
+++ b/src/mesa/state_tracker/st_extensions.c
@@ -348,7 +348,6 @@ void st_init_limits(struct pipe_screen *screen,
          screen->get_shader_param(screen, sh, PIPE_SHADER_CAP_INT16);
       options->LowerPrecisionConstants =
          screen->get_shader_param(screen, sh, PIPE_SHADER_CAP_GLSL_16BIT_CONSTS);
-      options->LowerPrecisionTemporaries = true;
    }
 
    c->MaxUserAssignableUniformLocations =