traceroute: pass INSTALL=$(INSTALL) as install time
authorThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Sun, 17 Dec 2017 08:56:04 +0000 (09:56 +0100)
committerThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Sun, 17 Dec 2017 08:56:04 +0000 (09:56 +0100)
As reported by Peter, using cp during the installation isn't correct,
as it follows symbolic links, potentially over-writing the busybox
binary through its traceroute symbolic link. To avoid that, we pass
INSTALL=$(INSTALL) during the installation step.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
package/traceroute/traceroute.mk

index 5d185a29004465be34d27ccd03f8691787ca7319..9d74b8fe3876e1d5ae90a8d15c219a6259285877 100644 (file)
@@ -23,7 +23,8 @@ endef
 
 define TRACEROUTE_INSTALL_TARGET_CMDS
        $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
-               DESTDIR=$(TARGET_DIR) prefix=/usr install -C $(@D)
+               DESTDIR=$(TARGET_DIR) prefix=/usr install \
+               INSTALL=$(INSTALL) -C $(@D)
 endef
 
 $(eval $(generic-package))