It's not necessary for a device to call recvDone, that

automatically happens in the interface after the packet
is delivered to the device.

--HG--
extra : convert_revision : 07890c4c5ce83fe709ce203f66c330d7cd631235

diff --git a/dev/ns_gige.cc b/dev/ns_gige.cc
index f6d15b02fa18d56b268506e7852a64213567760e..7e7fedc155990a6a91af82da58bb5b50e83c757f 100644 (file)
--- a/dev/ns_gige.cc
+++ b/dev/ns_gige.cc
@@ -2531,20 +2531,17 @@ NSGigE::recvPacket(PacketPtr packet)
 
     if (!rxEnable) {
         DPRINTF(Ethernet, "receive disabled...packet dropped\n");
-        interface->recvDone();
         return true;
     }
 
     if (!rxFilterEnable) {
         DPRINTF(Ethernet,
             "receive packet filtering disabled . . . packet dropped\n");
-        interface->recvDone();
         return true;
     }
 
     if (rxFilter(packet)) {
         DPRINTF(Ethernet, "packet filtered...dropped\n");
-        interface->recvDone();
         return true;
     }
 
@@ -2567,7 +2564,6 @@ NSGigE::recvPacket(PacketPtr packet)
     }
 
     rxFifo.push(packet);
-    interface->recvDone();
 
     rxKick();
     return true;

diff --git a/dev/sinic.cc b/dev/sinic.cc
index 0f2fd20eab5a24238e17a2355be8c06b15fb3777..0619a63dd1680939f71cd2f78491b93a0ecb2256 100644 (file)
--- a/dev/sinic.cc
+++ b/dev/sinic.cc
@@ -1085,13 +1085,11 @@ Device::recvPacket(PacketPtr packet)
 
     if (!rxEnable) {
         DPRINTF(Ethernet, "receive disabled...packet dropped\n");
-        interface->recvDone();
         return true;
     }
 
     if (rxFilter(packet)) {
         DPRINTF(Ethernet, "packet filtered...dropped\n");
-        interface->recvDone();
         return true;
     }
 
@@ -1104,7 +1102,6 @@ Device::recvPacket(PacketPtr packet)
         return false;
     }
 
-    interface->recvDone();
     devIntrPost(Regs::Intr_RxDone);
     rxKick();
     return true;