[PATCH] Fix undefined behaviour in rx port

[PATCH] Fix undefined behaviour in rx port
        * config/rx/constraints.md (Int08): Fix undefined left shift
        behaviour.
        (Sint08, Sint16, Sint24): Likewise.
        * config/rx/rx.c (rx_get_stack_layout): Likewise.

From-SVN: r228254

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index bc95889d4e3c53bfd937dedf5334643c27ee0ed0..cce1ba50244dcb0fc7fbbd7c74975743426ee8ad 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -12,6 +12,11 @@
 
 2015-09-29  Jeff Law  <law@redhat.com>
 
+       * config/rx/constraints.md (Int08): Fix undefined left shift
+       behaviour.
+       (Sint08, Sint16, Sint24): Likewise.
+       * config/rx/rx.c (rx_get_stack_layout): Likewise.
+
        * config/rl78/rl78-expand.md (movqi): Fix undefined left shift
        behaviour.
 

diff --git a/gcc/config/rx/constraints.md b/gcc/config/rx/constraints.md
index d46f9dac5ef0beb17a66d0f7d1beb8426116e256..b41c232fff1448de09831c9e980be292969844ed 100644 (file)
--- a/gcc/config/rx/constraints.md
+++ b/gcc/config/rx/constraints.md
@@ -28,28 +28,28 @@
 (define_constraint "Int08"
   "@internal A signed or unsigned 8-bit immediate value"
   (and (match_code "const_int")
-       (match_test "IN_RANGE (ival, (-1 << 8), (1 << 8) - 1)")
+       (match_test "IN_RANGE (ival, (HOST_WIDE_INT_M1U << 8), (1 << 8) - 1)")
   )
 )
 
 (define_constraint "Sint08"
   "@internal A signed 8-bit immediate value"
   (and (match_code "const_int")
-       (match_test "IN_RANGE (ival, (-1 << 7), (1 << 7) - 1)")
+       (match_test "IN_RANGE (ival, (HOST_WIDE_INT_M1U << 7), (1 << 7) - 1)")
   )
 )
 
 (define_constraint "Sint16"
   "@internal A signed 16-bit immediate value"
   (and (match_code "const_int")
-       (match_test "IN_RANGE (ival, (-1 << 15), (1 << 15) - 1)")
+       (match_test "IN_RANGE (ival, (HOST_WIDE_INT_M1U << 15), (1 << 15) - 1)")
   )
 )
 
 (define_constraint "Sint24"
   "@internal A signed 24-bit immediate value"
   (and (match_code "const_int")
-       (match_test "IN_RANGE (ival, (-1 << 23), (1 << 23) - 1)")
+       (match_test "IN_RANGE (ival, (HOST_WIDE_INT_M1U << 23), (1 << 23) - 1)")
   )
 )
 

diff --git a/gcc/config/rx/rx.c b/gcc/config/rx/rx.c
index c68f29ef6b6e1cf40fc0d664f265c3dcb4bb50b5..6d911d2edb8a32f3c08615ef75c8af300addb458 100644 (file)
--- a/gcc/config/rx/rx.c
+++ b/gcc/config/rx/rx.c
@@ -1561,7 +1561,7 @@ rx_get_stack_layout (unsigned int * lowest,
      PUSHM.
 
      FIXME: Is it worth improving this heuristic ?  */
-  pushed_mask = (-1 << low) & ~(-1 << (high + 1));
+  pushed_mask = (HOST_WIDE_INT_M1U << low) & ~(HOST_WIDE_INT_M1U << (high + 1));
   unneeded_pushes = (pushed_mask & (~ save_mask)) & pushed_mask;
 
   if ((fixed_reg && fixed_reg <= high)
@@ -1667,7 +1667,7 @@ ok_for_max_constant (HOST_WIDE_INT val)
 
   /* rx_max_constant_size specifies the maximum number
      of bytes that can be used to hold a signed value.  */
-  return IN_RANGE (val, (-1 << (rx_max_constant_size * 8)),
+  return IN_RANGE (val, (HOST_WIDE_INT_M1U << (rx_max_constant_size * 8)),
                        ( 1 << (rx_max_constant_size * 8)));
 }