pan/bi: Document constant count invariant
authorAlyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Tue, 5 May 2020 20:15:16 +0000 (16:15 -0400)
committerMarge Bot <eric+marge@anholt.net>
Fri, 29 May 2020 20:34:55 +0000 (20:34 +0000)
   constants + instructions <= 13

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5260>

src/panfrost/bifrost/compiler.h

index 43bd8bbc09facfa5fe8720464b8687fc82ba5f40..e4d37a8d52bc5bd16fd00a8c48fd259b252d697c 100644 (file)
@@ -373,7 +373,13 @@ typedef struct {
         /* Corresponds to the usual bit but shifted by a clause */
         bool data_register_write_barrier;
 
-        /* Constants read by this clause. ISA limit. */
+        /* Constants read by this clause. ISA limit. Must satisfy:
+         *
+         *      constant_count + bundle_count <= 13
+         *
+         * Also implicitly constant_count <= bundle_count since a bundle only
+         * reads a single constant.
+         */
         uint64_t constants[8];
         unsigned constant_count;